Repository navigation
Python: Separate message texts with a newline in AgentResponse.text - #10093
Open
Mikhail Grechannikov (Revinand) wants to merge 2 commits into
Open
Mikhail Grechannikov (Revinand) wants to merge 2 commits into
Mikhail Grechannikov (Revinand) wants to merge 2 commits into
Conversation
Mikhail Grechannikov (Revinand)
temporarily deployed
to
github-app-auth
November 4, 2026 11:57 — with
GitHub Actions
Inactive
Mikhail Grechannikov (Revinand)
had a problem deploying
to
github-app-auth
November 4, 2026 11:57 — with
GitHub Actions
Error
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change to separate non-empty response messages with newlines.
No open issues 🎉
What changed in this PR
Fixes #10067 by separating non-empty message texts in Python’s AgentResponse.text with newlines, preventing tool-call preambles from running into final answers. Structured .value parsing remains unchanged.
Changes:
- Join non-empty message texts with
"\n"and document the behavior. - Add regression coverage for messages surrounding a tool call and update existing text assertions.
| File | Description |
|---|---|
python/packages/core/tests/core/test_types.py |
Tests newline-separated output and omission of textless tool-result messages. |
python/packages/core/agent_framework/_types.py |
Updates AgentResponse.text joining logic and its docstring. |
Review effort: Balanced
Author
|
@microsoft-github-policy-service agree |
Mikhail Grechannikov (Revinand)
deployed
to
github-app-auth
November 10, 2026 14:54 — with
GitHub Actions
Active
Mikhail Grechannikov (Revinand)
deployed
to
github-app-auth
November 10, 2026 15:10 — with
GitHub Actions
Active
Muhammad Abdullah Butt (1AbdullahButt)
left a comment
There was a problem hiding this comment.
Looks correct. Here's what I checked.
- The new join (
_types.py:3787)."\n".join(text for msg in self.messages if (text := msg.text))skips messages whose.textis"", such as tool-result messages and function-call-only messages. So the tool loop in the new test gives"Let me check.\nIt is sunny."without a blank line. An emptymessageslist still gives"", so dropping theif self.messages else ""guard is safe. - Where a new message starts. In the streaming path,
_process_update(_types.py:2590-2615) starts a new message only when themessage_id,author_nameorrolechanges. Streamed chunks of one assistant message stay in a singleMessage, so the newline only appears at real message boundaries, not between chunks. - Callers.
as_tool()returnsfinal_response.text(_agents.py:873), and so does__str__. So the sub-agent text that goes back to the calling model now has the separator, which is the point of #10067. The only other in-core consumer,_workflows/_agent_executor.py:271, upper-cases the text and isn't affected by the join. .value. It still parses only the last message, and the updatedtest_agent_response_value_parses_final_message_with_response_formatassertion keeps.value.response == "Hello".git merge-treeagainstmainis clean.
Notes for the maintainers:
- The three
textproperties now differ slightly.Message.textjoins the text contents within a message with" "(_types.py:2475).ChatResponse.textjoins messages with"\n", doesn't skip empty ones, and.strip()s the result (:3476).AgentResponse.textnow joins with"\n", skips empty messages, and doesn't strip. The description already raises theChatResponsequestion. If the goal is one rule, sharing a helper between the two response types would keep them from drifting. - This changes user-visible output. It changes
str(response)andas_tool()results for multi-message responses, so it probably warrants a "Changed" line inpython/CHANGELOG.mdat release time. - Related draft. #10242 (draft, configurable response extraction for
as_tool()) touches the sameas_tool()return value, so it's worth looking at the two together.
I didn't run the tests.
Reviewed with help from Claude Code.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
AgentResponse.textjoins the texts of a response's messages with no separator. An agent that calls a tool returns the whole loop in one response, and a sentence the model writes before the tool call runs into the final answer:'Let me check the weather.It is sunny in Paris.'. The same text comes back fromstr(response)and from an agent wrapped withas_tool(), which returns it to the calling model..NET's
AgentResponse.Textputs a newline between the texts of non-empty messages (ConcatText), and Python'sChatResponse.textjoins its messages with"\n".Description & Review Guide
AgentResponse.textjoins the texts of non-empty messages with"\n"and skips messages without text, such as tool results, asConcatTextdoes. The docstring describes the separator. A new test covers a preamble with a tool call, a tool result and an answer. Two existing assertions pinned the joined output and now expect the newline:"HelloHello"becomes"Hello\nHello"intest_agent_run_response_text_property, and the two JSON documents intest_agent_response_value_parses_final_message_with_response_formatare separated by a newline. Its.valueassertions are unchanged..textputs a newline between those texts, andstr(response)and the result ofas_tool()change with it. Responses with one message or none return the same text as before..valueis not affected: it parses only the last message since Python: parse structured response value from final message #6383.ChatResponse.textshould match. It joins every message with"\n"and strips the result, and an empty message in the middle, such as a tool result, leaves a blank line:'Let me check.\n\nIt is sunny.'. I left it unchanged to keep this PR to .NET: Python: [Bug]: AgentResponse.text joins message texts without a separator #10067.Related Issue
Fixes #10067
No other open PR addresses this issue.
AI Assistance
AI assistance details: Claude Code helped with the issue analysis, the implementation, the tests and this description.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) - a workflow keeps the label and title prefix in sync automatically.