-
Notifications
You must be signed in to change notification settings - Fork 5k
Handling KSPROPERTY_CAMERACONTROL_EXTENDED_PROFILE on avscamera DMFT #1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 4 commits
68cc5fa
bc6eda8
93a1488
4a380c3
0960a1e
4ff5b33
efb9311
9ce1c2f
984a42b
0f0734b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,14 @@ | |
| #ifdef MF_WPP | ||
| #include "AvsCameraDMFT.tmh" //--REF_ANALYZER_DONT_REMOVE-- | ||
| #endif | ||
|
|
||
| // TODO: required to avoid bug OS bug 36971659 in extended property handling that introduces a 16 bytes cookie | ||
| typedef struct | ||
| { | ||
| //byte cookieBuffer[16]; | ||
| KSCAMERA_EXTENDEDPROP_HEADER header; | ||
| } KSCAMERA_EXTENDEDPROP_HEADER_BUFFERED, * PKSCAMERA_EXTENDEDPROP_HEADER_BUFFERED; | ||
|
|
||
| // | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove it is defined in ksmedia.h which should be already included |
||
| // This DeviceMFT is a stripped down implementation of the device MFT Sample present in the sample Repo | ||
| // The original DMFT is present at https://github.com/microsoft/Windows-driver-samples/tree/main/avstream/sampledevicemft | ||
|
|
@@ -18,8 +26,11 @@ CMultipinMft::CMultipinMft() | |
| m_lWorkQueuePriority ( 0 ), | ||
| m_spAttributes( nullptr ), | ||
| m_spSourceTransform( nullptr ), | ||
| m_SymbolicLink(nullptr) | ||
|
|
||
| m_SymbolicLink(nullptr), | ||
| m_hSelectedProfileKSEvent { nullptr }, | ||
| m_hSelectedProfileKSEventSentToDriver { nullptr}, | ||
| m_isProfileDDISupportedInBaseDriver{}, | ||
| m_selectedProfileId { KSCAMERAPROFILE_Legacy, 0, 0 } | ||
| { | ||
| HRESULT hr = S_OK; | ||
| ComPtr<IMFAttributes> pAttributes = nullptr; | ||
|
|
@@ -29,6 +40,7 @@ CMultipinMft::CMultipinMft() | |
| DMFTCHECKHR_GOTO(pAttributes->SetUINT32( MF_SA_D3D_AWARE, TRUE ), done); | ||
| DMFTCHECKHR_GOTO(pAttributes->SetString( MFT_ENUM_HARDWARE_URL_Attribute, L"SampleMultiPinMft" ),done); | ||
| m_spAttributes = pAttributes; | ||
|
|
||
|
||
| done: | ||
| DMFTRACE(DMFT_GENERAL, TRACE_LEVEL_INFORMATION, "%!FUNC! exiting %x = %!HRESULT!", hr, hr); | ||
| } | ||
|
|
@@ -638,6 +650,10 @@ IFACEMETHODIMP CMultipinMft::ProcessInput( | |
| goto done; | ||
| } | ||
|
|
||
| if (m_selectedProfileId.Type == KSCAMERAPROFILE_FaceAuth_Mode) | ||
| { | ||
| // DMFT might switch to different behavior when profile, KSCAMERAPROFILE_FaceAuth_Mode is selected. | ||
| } | ||
| DMFTCHECKHR_GOTO(spInPin->SendSample( pSample ), done ); | ||
| done: | ||
| DMFTRACE( DMFT_GENERAL, TRACE_LEVEL_INFORMATION, "%!FUNC! exiting %x = %!HRESULT!", hr, hr ); | ||
|
|
@@ -990,13 +1006,23 @@ IFACEMETHODIMP CMultipinMft::KsProperty( | |
| --*/ | ||
| { | ||
| HRESULT hr = S_OK; | ||
|
|
||
| /// PDMFT only cares about ExtendedCameraControls, all others | ||
| /// are just blindly forwarded to the upstream DMFTs. | ||
| if (!IsEqualCLSID(pProperty->Set, KSPROPERTYSETID_ExtendedCameraControl)) | ||
|
||
| { | ||
| DMFTCHECKHR_GOTO(m_spIkscontrol->KsProperty(pProperty, ulPropertyLength, pvPropertyData, | ||
| ulDataLength, pulBytesReturned), done); | ||
| goto done; | ||
| } | ||
|
|
||
| DMFTCHECKHR_GOTO(m_spIkscontrol->KsProperty(pProperty, | ||
| ulPropertyLength, | ||
| pvPropertyData, | ||
| ulDataLength, | ||
| pulBytesReturned),done); | ||
| if (pProperty->Id == KSPROPERTY_CAMERACONTROL_EXTENDED_PROFILE) | ||
|
||
| { | ||
| DMFTCHECKHR_GOTO(ProfilePropertyHandler(pProperty, ulPropertyLength, pvPropertyData, ulDataLength, pulBytesReturned), done); | ||
| goto done; | ||
|
||
| } | ||
| done: | ||
| DMFTRACE(DMFT_GENERAL, TRACE_LEVEL_INFORMATION, "%!FUNC! exiting %x = %!HRESULT!", hr, hr); | ||
| return hr; | ||
| } | ||
|
|
||
|
|
@@ -1041,14 +1067,66 @@ IFACEMETHODIMP CMultipinMft::KsEvent( | |
| { | ||
|
|
||
| HRESULT hr = S_OK; | ||
| // Handle the events here if you want, This sample passes the events to the driver | ||
| DMFTCHECKHR_GOTO(m_spIkscontrol->KsEvent(pEvent, | ||
| ulEventLength, | ||
| pEventData, | ||
| ulDataLength, | ||
| pBytesReturned), done); | ||
| // handle the event if it is to set profile | ||
| if (pEvent != nullptr | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what happens if this gets called twice before the first completes? |
||
| && ulEventLength >= sizeof(KSEVENT) | ||
| && pEvent->Set == KSEVENTSETID_ExtendedCameraControl | ||
| && pEventData != nullptr | ||
| && ulDataLength >= sizeof(KSEVENTDATA) | ||
| && (pEvent->Id == KSPROPERTY_CAMERACONTROL_EXTENDED_PROFILE)) | ||
| { | ||
|
|
||
| m_hSelectedProfileKSEvent = nullptr; | ||
|
||
| if (DuplicateHandle( | ||
| GetCurrentProcess(), | ||
| ((KSEVENTDATA*)(pEventData))->EventHandle.Event, | ||
| GetCurrentProcess(), | ||
| &m_hSelectedProfileKSEvent, | ||
| 0, | ||
| FALSE, | ||
| DUPLICATE_SAME_ACCESS) == false) | ||
| { | ||
| return E_INVALIDARG; | ||
|
||
| } | ||
| if (m_isProfileDDISupportedInBaseDriver.value_or(true)) | ||
| { | ||
| m_hSelectedProfileKSEventSentToDriver = CreateEventExW( | ||
|
||
| nullptr, | ||
| nullptr, | ||
| 0, | ||
| EVENT_ALL_ACCESS); | ||
|
|
||
| DMFTCHECKNULL_GOTO(m_hSelectedProfileKSEventSentToDriver, done, E_INVALIDARG); | ||
|
|
||
| KSEVENTDATA driverEventData = {}; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing size and data from original call |
||
| driverEventData.NotificationType = KSEVENTF_EVENT_HANDLE; | ||
| driverEventData.EventHandle.Event = m_hSelectedProfileKSEventSentToDriver; | ||
| DMFTRACE(DMFT_GENERAL, TRACE_LEVEL_INFORMATION, "Handling profile set KsEvent, created profile KsEvent handle for driver: %p", m_hSelectedProfileKSEventSentToDriver); | ||
|
|
||
| // defer to source device | ||
| hr = m_spIkscontrol->KsEvent(pEvent, ulEventLength, (void*)(&driverEventData), ulDataLength, pBytesReturned); | ||
| if (FAILED(hr)) | ||
| { | ||
| DMFTRACE(DMFT_GENERAL, TRACE_LEVEL_INFORMATION, "Failed to send profile KsEvent handle to driver: %p | hr=0x%08x", m_hSelectedProfileKSEventSentToDriver, hr); | ||
| m_hSelectedProfileKSEventSentToDriver = nullptr; | ||
| m_isProfileDDISupportedInBaseDriver = false; | ||
| } | ||
| } | ||
| } | ||
| else { | ||
| // Pass the events to the driver | ||
| hr = m_spIkscontrol->KsEvent(pEvent, | ||
| ulEventLength, | ||
| pEventData, | ||
| ulDataLength, | ||
| pBytesReturned); | ||
| if FAILED(hr) | ||
| { | ||
| return hr; | ||
| } | ||
| } | ||
| done: | ||
| return hr; | ||
| return S_OK; | ||
|
||
| } | ||
|
|
||
| // | ||
|
|
@@ -1293,6 +1371,102 @@ IFACEMETHODIMP CMultipinMft::Shutdown( | |
| return ShutdownEventGenerator(); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to handle canceling event and outstanding controls in shutdown
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Referring to the doc. above, extended profile is not cancelable. |
||
| } | ||
|
|
||
| /*++ | ||
| Description: | ||
| Implements the KsProperty KSPROPERTY_CAMERACONTROL_EXTENDED_PROFILE handler. | ||
| --*/ | ||
|
|
||
| HRESULT CMultipinMft::ProfilePropertyHandler( | ||
| _In_reads_bytes_(ulPropertyLength) PKSPROPERTY pProperty, | ||
| _In_ ULONG ulPropertyLength, | ||
| _In_ LPVOID pPropertyData, | ||
| _In_ ULONG ulDataLength, | ||
| _Inout_ PULONG pulBytesReturned) | ||
| { | ||
|
|
||
| UNREFERENCED_PARAMETER(ulPropertyLength); | ||
| HRESULT hr = S_OK; | ||
|
|
||
| if (pProperty->Flags & KSPROPERTY_TYPE_SET) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. check size |
||
| { | ||
| DMFTCHECKNULL_GOTO(pulBytesReturned, done, E_POINTER); | ||
| *pulBytesReturned = sizeof(KSCAMERA_EXTENDEDPROP_HEADER_BUFFERED) + sizeof(KSCAMERA_EXTENDEDPROP_PROFILE); | ||
| if (ulDataLength < *pulBytesReturned) | ||
| { | ||
| return HRESULT_FROM_WIN32(ERROR_MORE_DATA); | ||
| } | ||
| if (pPropertyData) | ||
| { | ||
|
|
||
| PBYTE pPayload = (PBYTE)pPropertyData; | ||
| PKSCAMERA_EXTENDEDPROP_HEADER pExtendedHeader = &((PKSCAMERA_EXTENDEDPROP_HEADER_BUFFERED)pPayload)->header; | ||
| KSCAMERA_EXTENDEDPROP_PROFILE* pProfile = (PKSCAMERA_EXTENDEDPROP_PROFILE)(pExtendedHeader + 1); | ||
|
|
||
| m_selectedProfileId.Type = pProfile->ProfileId; | ||
| m_selectedProfileId.Index = pProfile->Index; | ||
| m_selectedProfileId.Unused = pProfile->Reserved; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This information is never forwarded to the driver so the SentToDriver event will never signal. |
||
|
|
||
| if (m_selectedProfileId.Type == GUID_NULL) | ||
| { | ||
| DMFTRACE(DMFT_GENERAL, TRACE_LEVEL_WARNING, "The caller incorrectly sets GUID_NULL, default back to legacy."); | ||
| m_selectedProfileId = { KSCAMERAPROFILE_Legacy, 0, 0 }; | ||
| } | ||
|
|
||
| // signal we are done | ||
| if (m_hSelectedProfileKSEvent != nullptr) | ||
| { | ||
| if (m_hSelectedProfileKSEventSentToDriver != nullptr) | ||
| { | ||
| DMFTRACE(DMFT_GENERAL, TRACE_LEVEL_INFORMATION, "Waiting for driver profile KsEvent handle: %p", m_hSelectedProfileKSEventSentToDriver); | ||
| if ( WaitForSingleObjectEx(m_hSelectedProfileKSEventSentToDriver, kMAX_WAIT_TIME_DRIVER_PROFILE_KSEVENT, FALSE) != WAIT_OBJECT_0) | ||
| { | ||
|
|
||
| DMFTRACE(DMFT_GENERAL, TRACE_LEVEL_ERROR, | ||
| "Waiting for driver profile KsEvent handle: %p timed out after %i ms, failing", | ||
| m_hSelectedProfileKSEventSentToDriver, | ||
| kMAX_WAIT_TIME_DRIVER_PROFILE_KSEVENT); | ||
| SetEvent(m_hSelectedProfileKSEvent); | ||
| return HRESULT_FROM_WIN32(ERROR_TIMEOUT); | ||
| } | ||
| m_hSelectedProfileKSEventSentToDriver = nullptr; | ||
| } | ||
| SetEvent(m_hSelectedProfileKSEvent); | ||
| m_hSelectedProfileKSEvent = nullptr; | ||
| } | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wait should not block There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider using MFPutWaitingWorkItem to signal the m_hSelectedProfileKSEvent (using m_hSelectedProfileKSEventSentToDriver as the event handle to the API in question). This doesn't afford you the ability to use a timeout, but the spec requires drivers to signal the event both in the case of success or if the operation can't complete. |
||
| } | ||
| } | ||
| else if (pProperty->Flags & KSPROPERTY_TYPE_GET) | ||
| { | ||
| DMFTCHECKNULL_GOTO(pulBytesReturned, done, E_POINTER); | ||
| *pulBytesReturned = sizeof(KSCAMERA_EXTENDEDPROP_HEADER_BUFFERED) + sizeof(KSCAMERA_EXTENDEDPROP_PROFILE); | ||
| if (ulDataLength < *pulBytesReturned) | ||
| { | ||
| return HRESULT_FROM_WIN32(ERROR_MORE_DATA); | ||
| } | ||
| if (pPropertyData) | ||
| { | ||
| if (!m_isProfileDDISupportedInBaseDriver.has_value()) | ||
| { | ||
| hr = m_spIkscontrol->KsProperty(pProperty, ulPropertyLength, pPropertyData, ulDataLength, pulBytesReturned); | ||
| m_isProfileDDISupportedInBaseDriver = SUCCEEDED(hr); | ||
| DMFTRACE(DMFT_GENERAL, TRACE_LEVEL_INFORMATION, "Profile DDI GET support on base driver: %d, hr=0x%08x", m_isProfileDDISupportedInBaseDriver.value(), hr); | ||
| *pulBytesReturned = sizeof(KSCAMERA_EXTENDEDPROP_HEADER_BUFFERED) + sizeof(KSCAMERA_EXTENDEDPROP_PROFILE); | ||
| } | ||
| } | ||
| } | ||
| // --GETPAYLOAD-- | ||
| else if (pProperty->Flags & KSPROPERTY_TYPE_GETPAYLOADSIZE) | ||
| { | ||
| DMFTCHECKNULL_GOTO(pulBytesReturned, done, E_POINTER); | ||
| *pulBytesReturned = sizeof(KSCAMERA_EXTENDEDPROP_HEADER_BUFFERED) + sizeof(PKSCAMERA_EXTENDEDPROP_PROFILE); | ||
| } | ||
|
|
||
| done: | ||
| DMFTRACE(DMFT_GENERAL, TRACE_LEVEL_INFORMATION, "%!FUNC! exiting %x = %!HRESULT!", hr, hr); | ||
| return hr; | ||
| } | ||
|
|
||
|
|
||
| // | ||
| // Static method to create an instance of the MFT. | ||
| // | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,7 @@ | |
| #include "common.h" | ||
| #include "mftpeventgenerator.h" | ||
| #include "basepin.h" | ||
| #include <optional> | ||
|
|
||
| // | ||
| // The Below GUID is needed to transfer photoconfirmation sample successfully in the pipeline | ||
|
|
@@ -19,6 +20,8 @@ DEFINE_GUID(MFSourceReader_SampleAttribute_MediaType_priv, | |
|
|
||
| interface IDirect3DDeviceManager9; | ||
|
|
||
| constexpr int kMAX_WAIT_TIME_DRIVER_PROFILE_KSEVENT = 3000;// ms, amount of time to wait for the profile DDI KsEvent sent to the driver | ||
|
||
|
|
||
| // | ||
| // Forward declarations | ||
| // | ||
|
|
@@ -275,9 +278,18 @@ class CMultipinMft : | |
| _In_opt_ IMFMediaType *pMediaType, | ||
| _In_ DeviceStreamState newState | ||
| ); | ||
|
|
||
| HRESULT BridgeInputPinOutputPin( | ||
| _In_ CInPin* pInPin, | ||
| _In_ COutPin* pOutPin); | ||
|
|
||
| HRESULT ProfilePropertyHandler( | ||
| _In_reads_bytes_(ulPropertyLength) PKSPROPERTY pProperty, | ||
| _In_ ULONG ulPropertyLength, | ||
| _Inout_updates_to_(ulDataLength, *pulBytesReturned) LPVOID pPropertyData, | ||
| _In_ ULONG ulDataLength, | ||
| _Inout_ PULONG pulBytesReturned); | ||
|
|
||
| // | ||
| //Inline functions | ||
| // | ||
|
|
@@ -320,8 +332,14 @@ class CMultipinMft : | |
| UINT32 m_punValue; | ||
| ComPtr<IKsControl> m_spIkscontrol; | ||
| ComPtr<IMFAttributes> m_spAttributes; | ||
|
|
||
| map<int, int> m_outputPinMap; // How output pins are connected to input pins i-><0..outpins> | ||
| PWCHAR m_SymbolicLink; | ||
| HANDLE m_hSelectedProfileKSEvent; | ||
| HANDLE m_hSelectedProfileKSEventSentToDriver; | ||
| std::optional<bool> m_isProfileDDISupportedInBaseDriver; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't want drivers querying static info if they are shipped with specific HW if this changes dynamically it is probably a bug |
||
| SENSORPROFILEID m_selectedProfileId; | ||
|
|
||
| }; | ||
|
|
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -162,6 +162,7 @@ | |
| <ClCompile> | ||
| <PreprocessorDefinitions>%(PreprocessorDefinitions);UNICODE;MF_WPP;SECURITY_WIN32;MFT_UNIQUE_METHOD_NAMES;MF_DEVICEMFT_ALLOW_MFT0_LOAD</PreprocessorDefinitions> | ||
| <AdditionalIncludeDirectories>$(IntDir);%(AdditionalIncludeDirectories);..\..\common;..\common</AdditionalIncludeDirectories> | ||
| <LanguageStandard>stdcpp17</LanguageStandard> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| </ClCompile> | ||
| <Midl> | ||
| <PreprocessorDefinitions>%(PreprocessorDefinitions);UNICODE;MF_WPP;SECURITY_WIN32;MFT_UNIQUE_METHOD_NAMES;MF_DEVICEMFT_ALLOW_MFT0_LOAD</PreprocessorDefinitions> | ||
|
|
@@ -178,6 +179,7 @@ | |
| <ClCompile> | ||
| <PreprocessorDefinitions>%(PreprocessorDefinitions);UNICODE;MF_WPP;SECURITY_WIN32;MFT_UNIQUE_METHOD_NAMES;MF_DEVICEMFT_ALLOW_MFT0_LOAD</PreprocessorDefinitions> | ||
| <AdditionalIncludeDirectories>$(IntDir);%(AdditionalIncludeDirectories);..\..\common;..\common</AdditionalIncludeDirectories> | ||
| <LanguageStandard>stdcpp17</LanguageStandard> | ||
| </ClCompile> | ||
| <Midl> | ||
| <PreprocessorDefinitions>%(PreprocessorDefinitions);UNICODE;MF_WPP;SECURITY_WIN32;MFT_UNIQUE_METHOD_NAMES;MF_DEVICEMFT_ALLOW_MFT0_LOAD</PreprocessorDefinitions> | ||
|
|
@@ -194,6 +196,7 @@ | |
| <ClCompile> | ||
| <PreprocessorDefinitions>%(PreprocessorDefinitions);UNICODE;MF_WPP;SECURITY_WIN32;MFT_UNIQUE_METHOD_NAMES;MF_DEVICEMFT_ALLOW_MFT0_LOAD</PreprocessorDefinitions> | ||
| <AdditionalIncludeDirectories>$(IntDir);%(AdditionalIncludeDirectories);..\..\common;..\common</AdditionalIncludeDirectories> | ||
| <LanguageStandard>stdcpp17</LanguageStandard> | ||
| </ClCompile> | ||
| <Midl> | ||
| <PreprocessorDefinitions>%(PreprocessorDefinitions);UNICODE;MF_WPP;SECURITY_WIN32;MFT_UNIQUE_METHOD_NAMES;MF_DEVICEMFT_ALLOW_MFT0_LOAD</PreprocessorDefinitions> | ||
|
|
@@ -210,6 +213,7 @@ | |
| <ClCompile> | ||
| <PreprocessorDefinitions>%(PreprocessorDefinitions);UNICODE;MF_WPP;SECURITY_WIN32;MFT_UNIQUE_METHOD_NAMES;MF_DEVICEMFT_ALLOW_MFT0_LOAD</PreprocessorDefinitions> | ||
| <AdditionalIncludeDirectories>$(IntDir);%(AdditionalIncludeDirectories);..\..\common;..\common</AdditionalIncludeDirectories> | ||
| <LanguageStandard>stdcpp17</LanguageStandard> | ||
| </ClCompile> | ||
| <Midl> | ||
| <PreprocessorDefinitions>%(PreprocessorDefinitions);UNICODE;MF_WPP;SECURITY_WIN32;MFT_UNIQUE_METHOD_NAMES;MF_DEVICEMFT_ALLOW_MFT0_LOAD</PreprocessorDefinitions> | ||
|
|
@@ -237,6 +241,7 @@ | |
| <ItemGroup> | ||
| <None Exclude="@(None)" Include="*.txt;*.htm;*.html" /> | ||
| <None Exclude="@(None)" Include="*.ico;*.cur;*.bmp;*.dlg;*.rct;*.gif;*.jpg;*.jpeg;*.wav;*.jpe;*.tiff;*.tif;*.png;*.rc2" /> | ||
| <None Include="packages.config" /> | ||
| <None Include="Source.def" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <packages> | ||
| <package id="Microsoft.Windows.ImplementationLibrary" version="1.0.210204.1" targetFramework="native" /> | ||
| <package id="Microsoft.Windows.ImplementationLibrary" version="1.0.250325.1" targetFramework="native" /> | ||
| </packages> |

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented out code