Fix WSLc telemetry to fire critical events#40754
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates WSLC session/container creation logging so the emitted TraceLogging events are categorized as CRITICAL_DATA (not MEASURES+CRITICAL), aligning the keywording with the existing ExecCritical pattern.
Changes:
- Replace
WSL_LOG_TELEMETRY(...)withWSL_LOG(...)forWSLCCreateContainerandWSLCCreateSessionto avoid automatically adding theMICROSOFT_KEYWORD_MEASURESkeyword. - Change the events’ privacy tag usage to be passed explicitly via
TelemetryPrivacyDataTag(...).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/windows/wslcsession/WSLCSession.cpp | Switches container creation event from WSL_LOG_TELEMETRY to WSL_LOG to remove the MEASURES keyword. |
| src/windows/service/exe/WSLCSessionManager.cpp | Switches session creation event from WSL_LOG_TELEMETRY to WSL_LOG to remove the MEASURES keyword. |
OneBlue
previously approved these changes
Jun 9, 2026
ptrivedi
reviewed
Jun 9, 2026
ptrivedi
reviewed
Jun 9, 2026
ptrivedi
reviewed
Jun 9, 2026
OneBlue
approved these changes
Jun 9, 2026
Comment on lines
+1702
to
1706
| WSL_LOG( | ||
| "WSLCCreateContainer", | ||
| PDT_ProductAndServicePerformance, | ||
| TelemetryPrivacyDataTag(PDT_ProductAndServiceUsage), | ||
| TraceLoggingKeyword(MICROSOFT_KEYWORD_CRITICAL_DATA), | ||
| TraceLoggingValue(result, "Result"), |
Comment on lines
+325
to
329
| WSL_LOG( | ||
| "WSLCCreateSession", | ||
| PDT_ProductAndServicePerformance, | ||
| TelemetryPrivacyDataTag(PDT_ProductAndServiceUsage), | ||
| TraceLoggingKeyword(MICROSOFT_KEYWORD_CRITICAL_DATA), | ||
| TraceLoggingValue(resolvedDisplayName.c_str(), "Name"), |
benhillis
force-pushed
the
user/crloewen/critical-telemetry-fix
branch
from
0196fd8 to
ecb9fe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed WSLc events to be the exact same as the "ExecCritical" event. Right now it is showing up as "Measure+Critical" this change should make it show up just as "Critical"