Draft public sdk api for wsla #13827
Draft
+365
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OneBlue
reviewed
Dec 4, 2025
| set(SOURCES wsla.cpp) | ||
| set(HEADERS wsla.h) | ||
|
|
||
| add_library(wslasdk SHARED ${SOURCES} ${HEADERS} wslasdk.def) |
Collaborator
There was a problem hiding this comment.
I was originally of having the methods inside the wslaclient target, since it's essentially going to be the same thing conceptually.
I don't mind renaming it though, but if we do that let's delete the old target
OneBlue
reviewed
Dec 4, 2025
|
|
||
| // Container Process | ||
|
|
||
| STDAPI WslaCreateContainerProcess(_In_ WslaRuntimeContainer container, _In_ const WSLA_CONTAINER_PROCESS_OPTIONS* options, _Out_ WSLA_CONTAINER_PROCESS* process); |
Collaborator
There was a problem hiding this comment.
We might want to follow the COM logic a bit closer to make the integration easier.
Something like:
WslaGetContainerInitProcess(WslaRuntimeContainer container, WSLA_CONTAINER_PROCESS* process);
might be easier to implement
Author
There was a problem hiding this comment.
This one was the "nerdctl exec". I think you mean splitting CreateNewContainer into 2 methods? That works for me too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed