Fixed a crash related to variadic tuple elements with intersections containing InstantiableNonPrimitive - #64239
Open
Mateusz Burzyński (Andarist) wants to merge 1 commit into
Conversation
…ontaining `InstantiableNonPrimitive`
typescript-automation
Bot
added
the
For Uncommitted Bug
Copilot started reviewing on behalf of
Mateusz Burzyński (Andarist)
September 11, 2026 08:25
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix handles the reported intersection case and includes matching regression coverage.
Pull request overview
Prevents recursive variadic tuple normalization from overflowing when intersections contain generic instantiable types.
Changes:
- Detects generic types within unions or intersections.
- Adds regression coverage for issue #63040 and expected baselines.
File summaries
| File | Description |
|---|---|
tsc/internal/checker/checker.go |
Updates tuple normalization and adds a contained-type helper. |
tsc/testdata/tests/cases/compiler/recursiveConditionalCrash5.ts |
Adds the crash regression case. |
tsc/testdata/baselines/reference/compiler/recursiveConditionalCrash5.errors.txt |
Records the expected diagnostic. |
tsc/testdata/baselines/reference/compiler/recursiveConditionalCrash5.types |
Records inferred types. |
tsc/testdata/baselines/reference/compiler/recursiveConditionalCrash5.symbols |
Records resolved symbols. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #63040
recreates #63128