-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Test to document the crash in typescript-go#2039 #62739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to release-5.8 (microsoft#61178) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
…to release-5.8 (microsoft#61237) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
…to release-5.8 (microsoft#61423) Co-authored-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
…to release-5.8 (microsoft#61320) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
…to release-5.8 (microsoft#61345) Co-authored-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
…to release-5.8 (microsoft#61290) Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com> Co-authored-by: michaelm <michael.mitchell@airtable.com>
…to release-5.8 (microsoft#61453) Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
…to release-5.9 (microsoft#62164) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
…to release-5.9 (microsoft#62424) Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
…ft#62425) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
…to release-5.9 (microsoft#62426) Co-authored-by: Greggman <github@greggman.com>
…to release-5.9 (microsoft#62440) Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
…oft#62637) Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com> Co-authored-by: Andrew Branch <andrew@wheream.io>
…soft#62642) Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com> Co-authored-by: Andrew Branch <andrew@wheream.io>
…to tsgo-port (microsoft#62699) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
…port (microsoft#62701) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, and @joj for you. Feel free to loop in other consumers/maintainers if necessary. |
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
|
@jthemphill please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
Fixes microsoft/typescript-go#2039. Sort of.
Specifically, this creates a test and baseline that documents the correct behavior. From this test, we'll then automatically generate a failing test case in the typescript-go repository. Once we have a failing test case, writing a fix will be fairly easy.