Skip to content

fix(playground): enable noUncheckedIndexedAccess and exactOptionalPropertyTypes by default #3483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eranhirsch wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

fix(playground): enable noUncheckedIndexedAccess and exactOptionalPropertyTypes by default #3483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/sandbox/src/compilerOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ export function getDefaultSandboxCompilerOptions(
strictBindCallApply: true,
noImplicitThis: true,
noImplicitReturns: true,
noUncheckedIndexedAccess: false,
noUncheckedIndexedAccess: true,
exactOptionalPropertyTypes: true,

// 3.7 off, 3.8 on I think
useDefineForClassFields: false,
Expand Down Expand Up @@ -85,7 +86,8 @@ export const getCompilerOptionsFromParams = (
let toSet = undefined
if (val === "true" && playgroundDefaults[key] !== true) {
toSet = true
} else if (val === "false" && (playgroundDefaults[key] as any) !== false) { // TODO(jakebailey): remove as any, check undefined above
} else if (val === "false" && (playgroundDefaults[key] as any) !== false) {
// TODO(jakebailey): remove as any, check undefined above
toSet = false
} else if (!isNaN(parseInt(val, 10)) && playgroundDefaults[key] !== parseInt(val, 10)) {
toSet = parseInt(val, 10)
Expand Down