Repository navigation
TEST: Preserve LeakReplay end-to-end coverage - #4241
Open
Richard Lundeen (richlundeen) wants to merge 1 commit into
Open
Richard Lundeen (richlundeen) wants to merge 1 commit into
Richard Lundeen (richlundeen) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The test imports the runtime-only pyrit.scenario.garak alias without a targeted suppression, causing an unresolved-import failure in CI’s make ty check.
1 open issue
What changed in this PR
This PR extends the end-to-end harness’s coverage-preserving limit policy to LeakReplay, retaining all eight default technique-and-corpus populations.
Changes:
- Set LeakReplay’s end-to-end dataset limit to eight.
- Add a regression checking harness arguments against the real scenario configuration and expected populations.
| File | Description |
|---|---|
| tests/unit/scenario/test_scenario_e2e_contract.py | Verify LeakReplay harness settings preserve all default populations. |
| tests/end_to_end/test_scenarios.py | Add the LeakReplay-specific limit of eight. |
Review effort: Balanced
|
|
||
| from pyrit.cli.pyrit_scan import _build_run_request, parse_args | ||
| from pyrit.registry import ScenarioRegistry | ||
| from pyrit.scenario.garak import LeakReplay, LeakReplayDatasetConfiguration |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LeakReplay's two default techniques and four corpora require eight populations,
but the end-to-end harness currently supplies a limit of one.
configuration.
The limit policy and scenario were introduced in #3641 and #3689, respectively.