[BREAKING] FIX: Make commutative scorer evaluation identity order-independent - #2779
Merged
Richard Lundeen (richlundeen) merged 2 commits intoSep 23, 2026
Conversation
Opt built-in AND, OR, and MAJORITY composites into conditional child-hash sorting. Preserve duplicates, execution order, and ordered custom aggregates. Keep legacy identifiers fail-closed and document resume compatibility. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Roman Lutz (romanlutz)
approved these changes
Sep 23, 2026
Richard Lundeen (richlundeen)
deleted the
richlundeen-order-independent-scorer-identity
branch
September 23, 2026 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scenarios repeatedly failed to resume because equivalent composite scorers received different evaluation identities when their child order changed. I think this has been flagged 3-4 different times for individual scenarios, so trying a more robust fix
Add
Evaluate.Include(unordered_when="parent_param")to make child order irrelevant to evaluation identity only when explicitly enabled. The evaluation engine sorts projected child hashes after behavioral filtering and retains duplicates.TrueFalseCompositeScorerenables this for the built-in AND, OR, and MAJORITY functions. Equivalent permutations, including nested composites, now share evaluation identity and pass scenario resume checks. Custom aggregators and converter pipelines remain ordered. Execution and stored child order are unchanged.This change is independent of #2576 and does not modify the Garak exploitation scenario.