fix(converter): validate scale factor finiteness and guard against below-1-pixel dimensions in ImageResizingConverter#2169
Open
ThryLox wants to merge 1 commit into
Conversation
…low-1-pixel dimensions in ImageResizingConverter
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #2162 by adding robust input validation to ImageResizingConverter.
Description
Currently, ImageResizingConverter allows positive non-finite scale factors (such as math.nan or math.inf). Furthermore, scaling an image with a valid positive scale factor can truncate dimensions to zero (e.g., scaling a 1x1 image by 0.5), which raises an unhelpful Pillow ValueError: height and width must be > 0 deep inside the processing pipeline.
Changes