Scorer composition (PR C): roll pure-composition API out to remaining LLM scorers (3/3)#2157
Open
romanlutz wants to merge 4 commits into
Open
Conversation
Migrate the remaining LLM-based scorers off the transitional Scorer._score_value_with_llm_async forwarder to the pure v1.0 composition API and delete the base forwarder. Each scorer now stores chat_target + system_prompt + response_handler and calls _run_llm_scoring_async directly. Scorers migrated: - SelfAskQuestionAnswerScorer - SelfAskRefusalScorer - SelfAskCategoryScorer - SelfAskGeneralTrueFalseScorer - SelfAskScaleScorer - SelfAskLikertScorer - SelfAskGeneralFloatScaleScorer - InsecureCodeScorer Float-scale scorers bake numeric_value=True into the default JsonSchemaResponseHandler; identifiers read response_handler.response_schema. Preset construction moves to from_* factories (from_scale_arguments, from_likert_scale, from_content_classifier, from_question) with module-level render_*_system_prompt and load_scale_arguments helpers. Also migrate first-party consumers off the removed legacy constructors: crescendo, tree_of_attacks, fairness_bias (docstring example), fuzzer, and the scorer initializer registrations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Can you link you design gist? (update: found it, but it is convenient to have here :)) |
rlundeen2
reviewed
Jul 10, 2026
| @@ -53,7 +53,7 @@ async def test_likert_scorer_accepts_float_string_score_value( | |||
| chat_target.get_identifier.return_value = get_mock_target_identifier("MockChatTarget") | |||
| chat_target.send_prompt_async = AsyncMock(return_value=[scorer_likert_float_response]) | |||
Contributor
There was a problem hiding this comment.
docs for likert and category need an update because they need a system prompts
The PR changed the public constructors but did not update the executable doc notebooks (.py + paired .ipynb), which per docs.instructions.md are run end-to-end. These will now raise at construction time:
May be worth re-executing
rlundeen2
reviewed
Jul 10, 2026
| @@ -156,18 +327,4 @@ async def _score_piece_async(self, message_piece: MessagePiece, *, objective: st | |||
| return [score] | |||
|
|
|||
| def _validate_scale_arguments_set(self, scale_args: dict[str, Any]) -> None: | |||
Contributor
There was a problem hiding this comment.
Can we get rid of this function and similarly (for likert) _likert_scale_description_to_string
rlundeen2
reviewed
Jul 10, 2026
| chat_target: PromptTarget | None = None, | ||
| system_prompt: SeedPrompt | str | None = None, | ||
| response_handler: ResponseHandler | None = None, | ||
| min_value: int = 1, |
Contributor
There was a problem hiding this comment.
Nit: Should we get rid of min value and max value? Not sure, but if you pass in the system prompt they're ignored. I am on the fence.
rlundeen2
approved these changes
Jul 10, 2026
Covers chat_target=None guards, system_prompt str/invalid-type resolution, likert/scale/category system-prompt assembly validation, and refusal score_category normalization across the 7 migrated LLM scorers so diff-cover clears the 90 percent gate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Migrate all doc notebooks that constructed LLM scorers via the legacy keyword API (SelfAskTrueFalseScorer(true_false_question=...), SelfAskLikertScorer(likert_scale=...), SelfAskCategoryScorer(content_classifier_path=...)) to the new composition classmethods (from_question / from_likert_scale / from_content_classifier, with TrueFalseQuestion.from_yaml for path-based questions). Both paired .py and .ipynb files updated in sync. Freshly re-executed the core scorer/target notebooks (scoring/1, scoring/2, scoring/4, targets/1) to validate the new API end-to-end and refresh outputs. Remaining notebooks are code-migrated with preserved outputs (they require infra/targets not available in this environment). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Freshly re-ran executor/3_attack_configuration, executor/6_benchmark, executor/7_promptgen, targets/3_openai_image_target, and targets/round_robin_target to refresh outputs under the migrated scorer API. Normalized memory image paths in the image-target notebook to the repo-standard ./dbdata/ form. The Sora video notebook (targets/4) requires video-generation access unavailable here (execution aborted, left code-migrated). executor/8_modality_feedback executed successfully but was left at its code-migrated outputs to avoid a +7MB notebook-size increase. The 5 hard-infra notebooks (multi_turn, realtime, playwright, http, azure_sql) remain code-migrated with preserved outputs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final PR (3/3) of the scorer-architecture refactor ("Option 5 — scorer-owned composition"), following #2125 (ResponseHandler + internal round-trip helper) and #2146 (TrueFalse pure-composition API +
CallableResponseHandler), both now merged tomain.This rolls the pure v1.0 composition API out to the remaining LLM-based scorers and removes the last transitional forwarder. Each migrated scorer now stores
chat_target+system_prompt+ aresponse_handlerand calls the internal_run_llm_scoring_async(...)helper directly, instead of the baseScorer._score_value_with_llm_asyncforwarder (now deleted).Scorers migrated
SelfAskQuestionAnswerScorerSelfAskRefusalScorerSelfAskCategoryScorerSelfAskGeneralTrueFalseScorerSelfAskScaleScorerSelfAskLikertScorerSelfAskGeneralFloatScaleScorerInsecureCodeScorerDetails
numeric_value=Trueinto the defaultJsonSchemaResponseHandler; the schema is injected into the default handler only (a caller-supplied handler owns its own contract). Identifiers readresponse_handler.response_schema.from_*factories (from_scale_arguments,from_likert_scale,from_content_classifier,from_question) with module-levelrender_*_system_promptandload_scale_argumentshelpers mirroring the TrueFalse precedent from Scorer composition (PR B): TrueFalse pure-composition API + CallableResponseHandler #2146.Scorer._score_value_with_llm_asyncforwarder from the base class.crescendo,tree_of_attacks,fairness_bias(docstring example),fuzzer, and the scorer initializer registrations.Breaking changes (v1.0)
Legacy scorer constructors (e.g.
SelfAskScaleScorer(scale_arguments_path=...),SelfAskLikertScorer(likert_scale=...),SelfAskCategoryScorer(content_classifier_path=...),SelfAskRefusalScorer(refusal_system_prompt_path=...)) are replaced by the composition__init__plusfrom_*factories. This is an intentional v1.0 breaking change; no deprecation shims remain.Testing
tests/unit/score: 1311 passed, 16 skippedtests/unit/executor+tests/unit/setup(touched consumers): 1249 passed, 22 skippedruff check,ruff format --check,ty check pyrit: clean