Skip to content

FIX: Auto Preview of LLM based converters#1694

Merged
jbolor21 merged 1 commit intomicrosoft:mainfrom
jbolor21:bjagdagdorj/fix_llm_conversion_preview
May 6, 2026
Merged

FIX: Auto Preview of LLM based converters#1694
jbolor21 merged 1 commit intomicrosoft:mainfrom
jbolor21:bjagdagdorj/fix_llm_conversion_preview

Conversation

@jbolor21
Copy link
Copy Markdown
Contributor

@jbolor21 jbolor21 commented May 6, 2026

Description

ConverterTargets were changed from using PromptChatTarget to PromptTarget which broke the check in the GUI backend for LLM-based converters. This is necessary because we do not want LLM based converters to auto generate previews in the converter panel since this is expensive. Instead these need to wait for users to decide to preview.

Tests and Documentation

Wrote new tests to check the right converters are flagged as llm_based
All existing tests run
Manually checked via GUI.

Copy link
Copy Markdown
Contributor

@hannahwestra25 hannahwestra25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jbolor21 jbolor21 added this pull request to the merge queue May 6, 2026
Merged via the queue into microsoft:main with commit 55f65ca May 6, 2026
48 checks passed
@jbolor21 jbolor21 deleted the bjagdagdorj/fix_llm_conversion_preview branch May 6, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants