FIX: Render target capabilities as structured columns in config table#1691
Open
romanlutz wants to merge 6 commits intomicrosoft:mainfrom
Open
FIX: Render target capabilities as structured columns in config table#1691romanlutz wants to merge 6 commits intomicrosoft:mainfrom
romanlutz wants to merge 6 commits intomicrosoft:mainfrom
Conversation
- Add TargetCapabilitiesInfo model (6 boolean capability fields) to backend - Populate capabilities in target mapper from target_obj.capabilities - Add capability columns with checkmark/dismiss/dash indicators to TargetTable - Update Chat components to prefer capabilities object with legacy fallback - Add backend + frontend tests for capabilities population and rendering Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add target_configuration to extracted_keys so the verbose capabilities blob does not leak into the Parameters column - Make checkmark/dismiss icons 16px bold for better visibility - Add regression test for target_configuration filtering Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Switch to CheckmarkCircleFilled/DismissCircleFilled for better visibility - Add sticky header so column names stay visible when scrolling Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…capabilities-rendering
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The target config page was rendering capabilities as a verbose JSON blob inside the Parameters column. This PR restructures the rendering to show capabilities as dedicated columns with clear visual indicators.
Changes
Backend
pyrit/backend/models/targets.py: AddedTargetCapabilitiesInfoPydantic model with 6 boolean capability fields. Addedcapabilitiesfield toTargetInstance.pyrit/backend/mappers/target_mappers.py: Populatecapabilitiesfromtarget_obj.capabilities. Addedtarget_configurationtoextracted_keysto filter the verbose blob from Parameters.Frontend
frontend/src/types/index.ts: AddedTargetCapabilitiesInfointerface andcapabilitiesfield toTargetInstance.frontend/src/components/Config/TargetTable.tsx: Added 6 capability columns (Multi-turn, Multi-piece, JSON Schema, JSON Output, Edit History, System Prompt) with filled circle ✓/✗/— indicators and tooltip descriptions. Sticky table header for scroll visibility.frontend/src/components/Chat/ChatWindow.tsxandChatInputArea.tsx: Updatedsupports_multi_turnchecks to prefercapabilities?.supports_multi_turnwith legacy fallback.Tests
target_configurationexclusion.Testing
Screenshot