Skip to content

Refactor readers to reduce surface area #1958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baywet merged 2 commits into from
Dec 20, 2024

Moved load external references

c9b01cb
Select commit
Loading
Failed to load commit list.
Merged

Refactor readers to reduce surface area #1958

Moved load external references
c9b01cb
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Advanced Security / CodeQL completed Nov 26, 2024 in 5s

1 configuration not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 1 configuration present on refs/heads/vnext was not found:

API upload

  • ❓  <default>

New alerts in code changed by this pull request

  • 7 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 49 in src/Microsoft.OpenApi.Readers/OpenApiYamlReader.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning

Disposable 'StreamReader' is created but not disposed.

Check warning on line 76 in src/Microsoft.OpenApi.Readers/OpenApiYamlReader.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning

Disposable 'StreamReader' is created but not disposed.

Check warning on line 138 in src/Microsoft.OpenApi/Reader/OpenApiModelFactory.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning

Disposable 'MemoryStream' is created but not disposed.

Check warning on line 149 in src/Microsoft.OpenApi/Reader/OpenApiModelFactory.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
settings
Loading
may be null at this access because the parameter has a null default value.
Variable
settings
Loading
may be null at this access because the parameter has a null default value.

Check warning on line 179 in src/Microsoft.OpenApi/Reader/OpenApiModelFactory.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
settings
Loading
may be null at this access because the parameter has a null default value.
Variable
settings
Loading
may be null at this access because the parameter has a null default value.

Check warning on line 208 in src/Microsoft.OpenApi/Reader/OpenApiModelFactory.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning

Disposable 'MemoryStream' is created but not disposed.

Check warning on line 251 in src/Microsoft.OpenApi/Reader/OpenApiModelFactory.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning

Disposable 'MemoryStream' is created but not disposed.