Enable disabled dar linux tests#1560
Merged
Merged
Conversation
Re-enable 5 tests on GitHub Linux runners: - CoreDumpBasic, CoreDumpBasicMismatchedSourceAndSymbols, CoreDumpVerifyActions - ExecutionAsyncBreak - RunModeBreakpoints CI changes: - Set kernel.core_pattern=core so dumps land in CWD (debuggee output dir) - Set core_uses_pid=0 (test expects file named 'core', no PID suffix) - Disable apport service which intercepts core dumps on Ubuntu - Run tests in subshell with ulimit -c unlimited (scoped, resets on exit) Test fixes (latent bugs in previously-disabled tests): - CoreDumpVerifyActions: Assert.Contains args were inverted. xUnit signature is (expectedSubstring, actualString) but the test had them backwards. - ExecutionAsyncBreak: Test was sending pause before the inferior was running. Use a function breakpoint to confirm the loop is executing, then continue and async break. Also fix shouldExit access via 'this' (member variable). Relates to: #1170 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
WardenGnaw
changed the title
There was a problem hiding this comment.
Pull request overview
This PR re-enables several previously disabled Linux DAR tests by updating test exclusions, fixing latent assertions/test flow, and configuring Linux CI to allow core dump generation.
Changes:
- Re-enables selected GDB GNU Linux tests for core dumps, async break, and run-mode breakpoints.
- Fixes core dump assertion argument ordering and async-break test synchronization.
- Updates Linux CI to set core dump kernel settings and run tests with core dumps enabled.
Show a summary per file
| File | Description |
|---|---|
test/CppTests/Tests/ExecutionTests.cs |
Re-enables ExecutionAsyncBreak for GDB GNU and makes the pause sequence deterministic. |
test/CppTests/Tests/CoreDumpTests.cs |
Re-enables core dump tests for GDB GNU and fixes Assert.Contains usage. |
test/CppTests/Tests/BreakpointTests.cs |
Re-enables RunModeBreakpoints for GDB GNU. |
eng/Scripts/CI-Test.sh |
Runs tests in a subshell with core dump size limit set to unlimited. |
.github/workflows/Build-And-Test.yml |
Configures Linux runner kernel settings so core dumps are emitted as core. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 0
gregg-miskelly
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enable 5 tests on GitHub Linux runners:
CI changes:
Test fixes (latent bugs in previously-disabled tests):
Relates to: #1170