Skip to content

tree: Use normalized node IDs in fields - #28231

Draft
alex-pardes wants to merge 1 commit into
microsoft:mainfrom
alex-pardes:node-id-normalization
Draft

alex-pardes wants to merge 1 commit into
microsoft:mainfrom
alex-pardes:node-id-normalization

Conversation

@alex-pardes

@alex-pardes alex-pardes commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Description

When composing changesets, ModularChangeFamily was using change2's node IDs as canonical, while using change1's node IDs in the composed fields. This PR changes the implementation to use change1's node IDs as canonical, so the composed field changesets will contain the canonical IDs.

@github-actions github-actions Bot added area: tools area: dds Issues related to distributed data structures area: repo Repo related work area: website area: dds: tree base: main PRs targeted against main branch labels Sep 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (4 lines, 1 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

@github-actions

Copy link
Copy Markdown
Contributor

Bundle size comparison

Base commit: unresolved
Head commit: 64958f4173858d80eef9c1651bf27ceaf9f0c972

⚠️ Comparison unavailable.

The PR's CI build failed — fix the build and the comment will update once the next run succeeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: dds: tree area: dds Issues related to distributed data structures area: repo Repo related work area: tools area: website base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants