fix(client-map): restore IShareMap.forEach accuracy - #28193
Draft
Jason Hartman (jason-ha) wants to merge 5 commits into
Draft
Jason Hartman (jason-ha) wants to merge 5 commits into
Jason Hartman (jason-ha) wants to merge 5 commits into
Conversation
`FluidMap` does not provide `clear` and the lack of that bubbles through to appear as `Map` incompatibility even when `ISharedMap` and `ISharedDirectory` do provide them as `forEach` declarations type callback's `map` argument as `FluidMap`. Override `forEach` to restore the `Map` compatiblity right now easing customer transition to 3.x. See issue #27459.
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (55 lines, 5 files), I've queued these reviewers:
How this works
|
as it does call with `FluidMap`. Internally clarify that.
Since `FluidMap` is not intended to always be a subset of `Map` remove the cases where they are mixed. - `FluidMapLegacy.forEach` cannot support both. Only support `Map`. - `IShareMap` drops implementing `FluidMap.forEach`. Also update test comments.
Map compatibilityIShareMap.forEach accuracy
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
Contributor
Bundle size comparisonBase commit: Notable changesNo bundles changed by ≥ 500 bytes parsed. Per-bundle deltas
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FluidMapdoes not provideclearand the lack of that bubbles through to appear asMapincompatibility even whenISharedMapandISharedDirectorydo provide them asforEachdeclarations type callback'smapargument asFluidMap.Override
forEachto restore theMapcompatiblity right now easing customer transition to 3.x.See issue #27459.