Skip to content

promote FluidIterable, FluidIterableIterator, FluidReadonlyMap, FluidMap to public#27746

Draft
jenn-le wants to merge 1 commit into
mainfrom
promote-fluid-map-to-public
Draft

promote FluidIterable, FluidIterableIterator, FluidReadonlyMap, FluidMap to public#27746
jenn-le wants to merge 1 commit into
mainfrom
promote-fluid-map-to-public

Conversation

@jenn-le

@jenn-le jenn-le commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Description

Promotes FluidIterable, FluidIterableIterator, FluidReadonlyMap, and FluidMap from @beta to @public in @fluidframework/core-interfaces.

These sealed interfaces provide TypeScript-version-independent alternatives to the built-in Iterable, IterableIterator, ReadonlyMap, and Map types. They are now stable enough to be referenced in @public API surfaces, a follow-up PR will create a breaking change to migrate our types off of the built-in interfaces in the 3.0 release.

This is a non-breaking, additive change — no existing consumer code is affected.

Reviewer Guidance

The review process is outlined on this wiki page.

  • This is purely a release tag promotion (@beta@public). No functional changes.

…Map to @public

These sealed interfaces provide TypeScript-version-independent alternatives
to the built-in Iterable, IterableIterator, ReadonlyMap, and Map types.
They were previously @beta and are now promoted to @public so they can be
used in public API surfaces (e.g. TreeMapNode).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 22, 2026 21:05
@jenn-le
jenn-le requested review from a team as code owners July 22, 2026 21:05
@github-actions github-actions Bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: tools area: repo Repo related work area: website public api change Changes to a public API changeset-present base: main PRs targeted against main branch labels Jul 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (265 lines, 12 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

@github-actions

Copy link
Copy Markdown
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-website@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-website@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  306030 links
    1955 destination URLs
    2209 URLs ignored
       0 warnings
       0 errors


@jenn-le jenn-le changed the title Promote FluidIterable, FluidIterableIterator, FluidReadonlyMap, FluidMap to @public promote FluidIterable, FluidIterableIterator, FluidReadonlyMap, FluidMap to public Jul 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Bundle size comparison

Base commit: 4a1738e115bfbf0fe60fcc09d4685d56d2a2a918
Head commit: 0105d59ff1a77c67fdebe973a2bb0f24f7e96a1d

⚠️ Comparison unavailable.

The PR's CI build failed — fix the build and the comment will update once the next run succeeds.

@jenn-le
jenn-le marked this pull request as draft July 22, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: repo Repo related work area: tools area: website base: main PRs targeted against main branch changeset-present public api change Changes to a public API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants