feat(test-tools): Add with-test-port command to support tinylicious real service tests#27700
Draft
Josmithr wants to merge 16 commits into
Draft
feat(test-tools): Add with-test-port command to support tinylicious real service tests#27700Josmithr wants to merge 16 commits into
with-test-port command to support tinylicious real service tests#27700Josmithr wants to merge 16 commits into
Conversation
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (311 lines, 9 files), I've queued these reviewers:
How this works
|
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
with-test-portcommand, and updatesgetTestPortfunction so that they can be used to dynamically assign ports to tinylicious real service tests. Currently, packages that leverage these tests are required to hard-code repo-globally unique ports (in multiple locations, which must match) for their tinylicious service instances. This functionality will allow them to get their ports dynamically in a way that guarantees no conflicts between packages.This is part of a multi-PR effort to allow our repo's tinylicious real service tests to get port assignments dynamically.
This library update needs to be published before the changes can be used in the client packages. But the whole story can be previewed here: #27701.