Add node.js app insights package #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyuanliang-ms
requested review from
juniwang,
linglingye001,
rossgrambo and
samsadsam
rossgrambo
reviewed
Oct 31, 2024
sdk/feature-management-applicationinsights-node/src/telemetry.ts
Outdated
Show resolved
Hide resolved
…ent-JavaScript into zhiyuanliang/app-insights-node-package
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/app-insights-node-package
branch
from
f65473d to
fc961af
Compare
…ent-JavaScript into zhiyuanliang/app-insights-node-package
zhiyuanliang-ms
commented
Nov 7, 2024
rossgrambo
reviewed
Nov 7, 2024
rossgrambo
reviewed
Nov 7, 2024
| typescript({ | ||
| compilerOptions: { | ||
| "lib": [ | ||
| "DOM", |
Member
There was a problem hiding this comment.
Do we need DOM in this node package?
Member
Author
There was a problem hiding this comment.
I reused the rollup.config left by @Eskibear . I guess this is from some template? Will figure it out later. But in this PR, I don't mind keeping them.
rossgrambo
reviewed
Nov 7, 2024
rossgrambo
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.