Add additional telemetry dimension for EXP #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyuanliang-ms
requested review from
juniwang,
linglingye001,
mrm9084,
rossgrambo and
zhenlan
juniwang
reviewed
Oct 23, 2024
| } | ||
| } | ||
| } | ||
| eventProperties["PercentileAllocationPercentage"] = (100 - percentileAllocationPercentage).toString(); |
Member
There was a problem hiding this comment.
the percentage seems to include percentrage of all other unassigned variants, please confirm the design
Member
Author
There was a problem hiding this comment.
I referenced the old pr. There was a bug. It is fixed in the latest PR: microsoft/FeatureManagement-Python#45
juniwang
reviewed
Oct 24, 2024
sdk/feature-management-applicationinsights-browser/src/telemetry.ts
Outdated
Show resolved
Hide resolved
juniwang
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://github.com/microsoft/FeatureManagement-Python/pull/41/files (original implementation)
microsoft/FeatureManagement-Python#45 (bug fix)