Skip to content

Reorganize EventLogExpert.Eventing folders, tighten API surface, and split unit/integration tests #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jschick04 wants to merge 24 commits into
base: jschick/move-modals-to-components
Choose a base branch
from
Draft

Reorganize EventLogExpert.Eventing folders, tighten API surface, and split unit/integration tests #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
860b211
Move P/Invoke types to Interop folder and rename Interop class to Win…
jschick04 May 7, 2026
fbf9890
Move and rename internal interop classes to Interop folder
jschick04 May 7, 2026
f5b7334
Split Helpers/EventMethods.cs into Interop partials and extract LoadL…
jschick04 May 7, 2026
fab0219
Move PathType to Readers namespace
jschick04 May 7, 2026
3eeabdc
Delete dead Eventing.Helpers.ExtensionMethods extension
jschick04 May 7, 2026
c2758c8
Move SeverityLevel and Severity to Models namespace
jschick04 May 7, 2026
b471715
Move Helpers types to Logging and Readers
jschick04 May 7, 2026
7b29a46
Internalize Eventing surface and seal EventXmlResolver
jschick04 May 7, 2026
e9ac305
Migrate Eventing InternalsVisibleTo to csproj
jschick04 May 7, 2026
c380b4b
Move Eventing.Tests Helpers tests into Interop and Readers
jschick04 May 7, 2026
85f2a16
Remove tautological and vacuous tests from Eventing.Tests
jschick04 May 7, 2026
31ef599
Replace EventLogWatcher test sleeps with signals and cancellable delays
jschick04 May 7, 2026
aa503bc
Fix EventLogInformation invalid-handle check and replace ThrowsAny<Ex…
jschick04 May 7, 2026
927488f
Replace conditional logic in test bodies with deterministic fixtures …
jschick04 May 7, 2026
419f307
Split Eventing tests into unit and integration projects
jschick04 May 7, 2026
eacaa22
Tighten RegistryProvider integration test probes
jschick04 May 7, 2026
67cf05b
Tighten thread-safety and vacuity in EventLogWatcherTests
jschick04 May 7, 2026
98c0854
Strengthen resolver fallback tests and convert provider loop to Theory
jschick04 May 8, 2026
be201ac
Isolate handler exceptions and reject reentrant stop in EventLogWatcher
jschick04 May 8, 2026
5e8481e
Strip overlong comments and tighten EventLogWatcher XML doc/impl alig…
jschick04 May 8, 2026
64dea41
Honor alignment in span AppendFormatted and drain initial backlog out…
jschick04 May 8, 2026
7573962
Use Volatile reads/writes for _isSubscribed and drain backlog before …
jschick04 May 8, 2026
e9f240c
Pass resolved Win32 message to UnauthorizedAccessException
jschick04 May 8, 2026
81c9daa
Release native subscription handle and ThreadPool wait on finalizer path
jschick04 May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/PullRequest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,6 @@ jobs:
- name: Build
run: dotnet build EventLogExpert.slnx --no-restore
- name: Test
run: dotnet test EventLogExpert.slnx --no-build --verbosity normal
run: dotnet test EventLogExpert.slnx --no-build --verbosity normal --filter "FullyQualifiedName!~EventLogExpert.Eventing.IntegrationTests"
- name: Integration Test
run: dotnet test EventLogExpert.Eventing.IntegrationTests/EventLogExpert.Eventing.IntegrationTests.csproj --no-build --verbosity normal
2 changes: 1 addition & 1 deletion src/EventLogExpert.Components.Tests/BannerHostTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// // Licensed under the MIT License.

using Bunit;
using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using EventLogExpert.UI;
using EventLogExpert.UI.Interfaces;
using EventLogExpert.UI.Models;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.Components.Tests/Database/DatabaseRecoveryDialogTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

using Bunit;
using EventLogExpert.Components.Database;
using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using EventLogExpert.UI;
using EventLogExpert.UI.Interfaces;
using EventLogExpert.UI.Models;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.Components.Tests/Database/DatabaseRecoveryHostTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

using Bunit;
using EventLogExpert.Components.Database;
using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using EventLogExpert.UI;
using EventLogExpert.UI.Interfaces;
using EventLogExpert.UI.Models;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.Components.Tests/Database/SettingsUpgradeProgressBannerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

using Bunit;
using EventLogExpert.Components.Database;
using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using EventLogExpert.UI.Interfaces;
using EventLogExpert.UI.Models;
using Microsoft.Extensions.DependencyInjection;
Expand Down
6 changes: 3 additions & 3 deletions src/EventLogExpert.Components/BannerHost.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// // Copyright (c) Microsoft Corporation.
// // Licensed under the MIT License.

using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using EventLogExpert.UI.Interfaces;
using EventLogExpert.UI.Models;
using EventLogExpert.UI.Services;
Expand Down Expand Up @@ -261,14 +261,14 @@ private async Task OnReloadClickedAsync()

_displayedIndex = i;
_selectedItem = items[i];

return (_selectedItem, _selectedItem.View);
}
}

_displayedIndex = Math.Clamp(_displayedIndex, 0, items.Count - 1);
_selectedItem = items[_displayedIndex];

return (_selectedItem, _selectedItem.View);
}
}
2 changes: 1 addition & 1 deletion src/EventLogExpert.Components/Database/DatabaseRecoveryDialog.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// // Licensed under the MIT License.

using EventLogExpert.Components.Base;
using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using EventLogExpert.UI.Interfaces;
using EventLogExpert.UI.Models;
using Microsoft.AspNetCore.Components;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.Components/Database/DatabaseRecoveryHost.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// // Copyright (c) Microsoft Corporation.
// // Licensed under the MIT License.

using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using EventLogExpert.UI.Interfaces;
using EventLogExpert.UI.Models;
using Microsoft.AspNetCore.Components;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.Components/Database/SettingsUpgradeProgressBanner.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// // Copyright (c) Microsoft Corporation.
// // Licensed under the MIT License.

using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using EventLogExpert.UI.Interfaces;
using EventLogExpert.UI.Models;
using Microsoft.AspNetCore.Components;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.Components/Filters/SubFilterRow.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ public sealed partial class SubFilterRow : FilterRowBase<SubFilterDraft>
[Parameter] public EventCallback<FilterId> OnRemove { get; set; }

private async Task RemoveSubFilter() => await OnRemove.InvokeAsync(Value.Id);
}
}
2 changes: 1 addition & 1 deletion src/EventLogExpert.Components/Menu/MenuBar.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// // Copyright (c) Microsoft Corporation.
// // Licensed under the MIT License.

using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Readers;
using EventLogExpert.UI;
using EventLogExpert.UI.Interfaces;
using EventLogExpert.UI.Models;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.EventDbTool.Tests/DiffDatabaseCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
using EventLogExpert.EventDbTool.Tests.TestUtils;
using EventLogExpert.EventDbTool.Tests.TestUtils.Constants;
using EventLogExpert.Eventing.EventProviderDatabase;
using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using NSubstitute;

namespace EventLogExpert.EventDbTool.Tests;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.EventDbTool.Tests/MergeDatabaseCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

using EventLogExpert.EventDbTool.Tests.TestUtils;
using EventLogExpert.EventDbTool.Tests.TestUtils.Constants;
using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using NSubstitute;

namespace EventLogExpert.EventDbTool.Tests;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.EventDbTool.Tests/ProviderSourceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

using EventLogExpert.EventDbTool.Tests.TestUtils;
using EventLogExpert.EventDbTool.Tests.TestUtils.Constants;
using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using NSubstitute;

namespace EventLogExpert.EventDbTool.Tests;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.EventDbTool.Tests/UpgradeDatabaseCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

using EventLogExpert.EventDbTool.Tests.TestUtils;
using EventLogExpert.Eventing.EventProviderDatabase;
using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using NSubstitute;

namespace EventLogExpert.EventDbTool.Tests;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.EventDbTool/CreateDatabaseCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// // Licensed under the MIT License.

using EventLogExpert.Eventing.EventProviderDatabase;
using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using EventLogExpert.Eventing.Providers;
using Microsoft.Extensions.DependencyInjection;
using System.CommandLine;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.EventDbTool/DbToolCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// // Copyright (c) Microsoft Corporation.
// // Licensed under the MIT License.

using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using EventLogExpert.Eventing.Providers;
using EventLogExpert.Eventing.Readers;
using System.Text.RegularExpressions;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.EventDbTool/DiffDatabaseCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// // Licensed under the MIT License.

using EventLogExpert.Eventing.EventProviderDatabase;
using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using EventLogExpert.Eventing.Providers;
using Microsoft.Extensions.DependencyInjection;
using System.CommandLine;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.EventDbTool/MergeDatabaseCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// // Licensed under the MIT License.

using EventLogExpert.Eventing.EventProviderDatabase;
using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using EventLogExpert.Eventing.Providers;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.DependencyInjection;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.EventDbTool/MtaProviderSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// // Copyright (c) Microsoft Corporation.
// // Licensed under the MIT License.

using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using EventLogExpert.Eventing.Providers;
using EventLogExpert.Eventing.Readers;
using System.Text.RegularExpressions;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.EventDbTool/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// // Copyright (c) Microsoft Corporation.
// // Licensed under the MIT License.

using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;
using System.CommandLine;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.EventDbTool/ProviderSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// // Licensed under the MIT License.

using EventLogExpert.Eventing.EventProviderDatabase;
using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using EventLogExpert.Eventing.Providers;
using Microsoft.EntityFrameworkCore;
using System.Data.Common;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.EventDbTool/RegexHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// // Copyright (c) Microsoft Corporation.
// // Licensed under the MIT License.

using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using System.Text.RegularExpressions;

namespace EventLogExpert.EventDbTool;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.EventDbTool/ShowCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// // Copyright (c) Microsoft Corporation.
// // Licensed under the MIT License.

using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using EventLogExpert.Eventing.Providers;
using Microsoft.Extensions.DependencyInjection;
using System.CommandLine;
Expand Down
2 changes: 1 addition & 1 deletion src/EventLogExpert.EventDbTool/UpgradeDatabaseCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// // Licensed under the MIT License.

using EventLogExpert.Eventing.EventProviderDatabase;
using EventLogExpert.Eventing.Helpers;
using EventLogExpert.Eventing.Logging;
using Microsoft.Extensions.DependencyInjection;
using System.CommandLine;
using System.Data.Common;
Expand Down
17 changes: 17 additions & 0 deletions src/EventLogExpert.Eventing.IntegrationTests/EventLogExpert.Eventing.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<IsPackable>false</IsPackable>
<IsTestProject>true</IsTestProject>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\EventLogExpert.Eventing\EventLogExpert.Eventing.csproj" />
</ItemGroup>

<ItemGroup>
<Compile Include="..\EventLogExpert.Eventing.Tests\TestUtils\Constants\Constants.Provider.cs" Link="TestUtils\Constants\Constants.Provider.cs" />
</ItemGroup>

Comment thread
jschick04 marked this conversation as resolved.
</Project>
1 change: 1 addition & 0 deletions src/EventLogExpert.Eventing.IntegrationTests/GlobalUsings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
global using Xunit;
Loading