Update release issue template to handle latest release procedure - #8757
Update release issue template to handle latest release procedure#8757joaosaffran wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the release issue template to reflect the latest SPIR-V release process.
Changes:
- Adds final branch synchronization and SPIR-V submodule updates.
- Replaces Google sign-off with NVIDIA sign-off.
- Adds LunarG release notification.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| - [ ] Tag final release and post binaries | ||
| - [ ] Add the new compiler to Compiler Explorer | ||
| - [ ] Email LunarG the release tag and update the release spreadsheet. |
There was a problem hiding this comment.
Does this still apply to all spot releases/releases? I think it will only apply to when we are doing a release alongside LunarG?
There was a problem hiding this comment.
Yes, it only applies for when we are releasing alongside LunarG. However this issue doesn't seem to distinguish between different releases. For example, it doesn't specify what is part of a spot release or a full release.
There was a problem hiding this comment.
I think that's because we weren't consistently creating issues for spot releases before. Maybe now is a good time to add the differentiation? Or maybe it's obvious enough when it doesn't apply
There was a problem hiding this comment.
We should probably have a different issue for each. Or maybe a branch within the issue. I've done a number of point releases using the release issue and its always awkward
There was a problem hiding this comment.
I like the idea of having a different issue for point releases, but I still think that those will have a bunch of branches within them, depending on where we release and what we are releasing.
There was a problem hiding this comment.
We already have too many issue templates, I'm not keen on adding another one. I think instructions to "delete as appropriate" or maybe being able to list some as "point release only" or "major release only" would work.
Another tool we have is that we can put HTML comments or other instructions into the template - it's reasonable to expect the person creating the new release to have to edit / customize it a bit. We already expect them to fill in the dates, for example.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.github/ISSUE_TEMPLATE/release.md:56
- Use the official
NuGetcapitalization, consistent with the package name on line 39 and inREADME.md.
- [ ] Publish the new compiler Nuget package.
This patch updates the Release issue template to also account for the SPIRV SDK release and to account for NVIDIA validating SPIRV instead of google.
Fix: microsoft/hlsl-specs#888