[DxilSimplify] Constant-fold VectorReduce.*#8577
Open
llvm-beanz wants to merge 1 commit into
Open
Conversation
Add support for constant-evaluating VectorReduce operations on constant operands. This restores optimization pairity between SM 6.8 and SM 6.9. Assisted by Claude Opus 4.8 ../tools/clang/test/DXC/Passes/DxilSimplify/vectorreduce-const-fold.ll
V-FEXrt
approved these changes
Jun 22, 2026
hekota
approved these changes
Jun 26, 2026
Comment on lines
+106
to
+112
| declare i1 @dx.op.vectorReduce.v4i1(i32, <4 x i1>) #0 | ||
| declare i32 @dx.op.vectorReduce.v4i32(i32, <4 x i32>) #0 | ||
| declare void @dx.op.storeOutput.i32(i32, i32, i32, i8, i32) #1 | ||
|
|
||
| attributes #0 = { nounwind readnone } | ||
| attributes #1 = { nounwind } | ||
|
|
Member
There was a problem hiding this comment.
Just a nit - I don't think this needs to be here.
Suggested change
| declare i1 @dx.op.vectorReduce.v4i1(i32, <4 x i1>) #0 | |
| declare i32 @dx.op.vectorReduce.v4i32(i32, <4 x i32>) #0 | |
| declare void @dx.op.storeOutput.i32(i32, i32, i32, i8, i32) #1 | |
| attributes #0 = { nounwind readnone } | |
| attributes #1 = { nounwind } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for constant-evaluating VectorReduce operations on constant operands. This restores optimization parity between SM 6.8 and SM 6.9.
Fixes #8570
Assisted by Claude Opus 4.8