Cherry-Pick #7587: Address compiler warnings: Enable warning C4146 as a break#8240
Draft
alsepkow wants to merge 1 commit intomicrosoft:release-1.8.2505from
Draft
Conversation
…t#7587) Addresses microsoft#7584 by removing the warning disable for 4146. Also includes a few trivial fixes for C4146 across several files that were missed in previous PRs.
alsepkow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #7587 into release-1.8.2505.
Original PR: #7587
Original Commit: 94abfe9
Note: This PR promotes C4146 to an error. The other C4146 fix PRs (#7551, #7556, #7559, #7562, #7567, #7574) should be merged first.
Assisted by GitHub Copilot.