Add D3D12SDK class to manage choosing and configuring the SDK #7879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
You can test this locally with the following command:git-clang-format --diff bcb1bca39e5a1a1a2bbc78807633778b1f003306 f40b3fddc773a956ade735242882aa002d99c3e7 -- tools/clang/unittests/HLSLExec/ExecutionTest.cpp tools/clang/unittests/HLSLExec/HlslExecTestUtils.cpp tools/clang/unittests/HLSLExec/HlslExecTestUtils.h tools/clang/unittests/HLSLExec/LongVectors.cppView the diff from clang-format here.diff --git a/tools/clang/unittests/HLSLExec/HlslExecTestUtils.h b/tools/clang/unittests/HLSLExec/HlslExecTestUtils.h
index bc76cbbd..692b4b86 100644
--- a/tools/clang/unittests/HLSLExec/HlslExecTestUtils.h
+++ b/tools/clang/unittests/HLSLExec/HlslExecTestUtils.h
@@ -39,11 +39,11 @@ bool useDxbc();
/// directory. Absolute path is only supported on OS's that support
/// ID3D12DeviceFactory.
///
-/// D3D12SDKVersion: requested SDK version
+/// D3D12SDKVersion: requested SDK version
///
-/// 0: auto-detect (quietly fallback to inbox version)
+/// 0: auto-detect (quietly fallback to inbox version)
///
-/// 1: auto-detect (fail if unable to use the auto-detected version)
+/// 1: auto-detect (fail if unable to use the auto-detected version)
///
/// >1: use specified version
class D3D12SDK {
|
damyanp
commented
Nov 6, 2025
| InitializeOpTests(void *pStrCtx, st::OutputStringFn pOutputStrFn) { | ||
| InitializeOpTests([[maybe_unused]] void *pStrCtx, | ||
| [[maybe_unused]] st::OutputStringFn pOutputStrFn) { | ||
| #ifdef _FORCE_EXPERIMENTAL_SHADERS |
Member
Author
There was a problem hiding this comment.
Change my view: in the original version of this, enableExperimentalMode will always return S_FALSE and not actually do anything.
Note that InitializeOpTests is called from that GUI thing that's a bit like godbolt, so there won't be any taef runtime params to look at. As far as I can tell, _FORCE_EXPERIMENTAL_SHADERS is never defined.
Member
Author
|
#7963 replaces this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress - this gets the "global" version working (global is what we have now). To do is adding the "independent device" version - this allows us to select the AgilitySDK using an absolute path which eventually will allow us to use these tests with lit without having to copy te.exe to strange places.