Fix CCW discovery for generated bindable property values - #2529
Open
Tom McDonald (tommcdon) wants to merge 1 commit into
Open
Fix CCW discovery for generated bindable property values#2529Tom McDonald (tommcdon) wants to merge 1 commit into
Tom McDonald (tommcdon) wants to merge 1 commit into
Conversation
Ensure property values exposed through GeneratedBindableCustomProperty contribute their concrete types to the generated CCW lookup table. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2458.
GeneratedBindableCustomPropertygenerates accessors that return bindableproperty values through
object, but those generated accessors cannot beanalyzed by the same source-generator pass. For getter-only collection
properties, the concrete return type was therefore omitted from
WinRTGlobalVtableLookup.g.csunless another authored or XAML-generatedexpression happened to expose it across the WinRT ABI.
This caused UWP XAML bindings such as
ItemsSource="{Binding DisplayItems}"to return anObservableCollection<string>without registering itsIVector<string>CCW projection. Applications had to add an unrelated property to the page
code-behind or explicitly use
GeneratedWinRTExposedExternalTypeto rootthe collection.
Changes
property initializers, expression-bodied properties, and block-bodied
getter returns.
Validation