Repository navigation
Remove the lockfiles of the archived k.direct-line-token sample - #6025
Open
Eugene (OEvgeny) wants to merge 2 commits into
Open
Eugene (OEvgeny) wants to merge 2 commits into
Eugene (OEvgeny) wants to merge 2 commits into
Conversation
added 2 commits
November 6, 2026 04:12
Eugene (OEvgeny)
marked this pull request as ready for review
November 6, 2026 14:08
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
Thomas Durnford (tdurnford)
as code owners
November 6, 2026 14:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Changed
k.direct-line-token, and skipped it innpm run bump, in PR #6025, by @OEvgenyDescription
The sample was archived in #5537, which removed its lockfiles, but
npm run bumpstill ran in it and recreated them in #5659. This PR deletes both lockfiles and skips the sample innpm run bump, as #5533 did for07.advanced-web-chat-apps.Design
zodneeds a major thatbotbuilderdoes not support yet.Specific Changes
k.direct-line-token/javascript/{bot,web}/package-lock.jsonsamples/package.json:bump:non-workspacesskips*/k.direct-line-token/*, like*/07.advanced-web-chat-apps/*I have added tests and executed them locally.changelog/<PR#>-<slug>.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)