Skip to content

Remove the lockfiles of the archived k.direct-line-token sample - #6025

Open
Eugene (OEvgeny) wants to merge 2 commits into
mainfrom
OEvgeny/archive-k-direct-line-token-lockfiles
Open

Eugene (OEvgeny) wants to merge 2 commits into
mainfrom
OEvgeny/archive-k-direct-line-token-lockfiles

Conversation

@OEvgeny

@OEvgeny Eugene (OEvgeny) commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

The archived 01.getting-started/k.direct-line-token sample still ships package-lock.json files, which carry 5 Dependabot alerts.

Changelog Entry

Changed

  • 🏫 Samples: removed lockfiles of archived k.direct-line-token, and skipped it in npm run bump, in PR #6025, by @OEvgeny

Description

The sample was archived in #5537, which removed its lockfiles, but npm run bump still ran in it and recreated them in #5659. This PR deletes both lockfiles and skips the sample in npm run bump, as #5533 did for 07.advanced-web-chat-apps.

Design

  • Delete instead of upgrading: restify 11 already crashes the sample at startup, and fixing zod needs a major that botbuilder does not support yet.

Specific Changes

  • Deleted k.direct-line-token/javascript/{bot,web}/package-lock.json
  • samples/package.json: bump:non-workspaces skips */k.direct-line-token/*, like */07.advanced-web-chat-apps/*
  • I have added tests and executed them locally
  • I have added .changelog/<PR#>-<slug>.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

Eugene Olonov added 2 commits November 6, 2026 04:12
…n bump

The lockfiles were removed in #5537 and #5540 but recreated by `npm run bump`
in #5659. Skip the sample in bump:non-workspaces like 07.advanced-web-chat-apps.
@OEvgeny
Eugene (OEvgeny) marked this pull request as ready for review November 6, 2026 14:08
Copilot AI balanced review requested due to automatic review settings November 6, 2026 14:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants