Skip to content

Conversation

@ben-childs-docusign
Copy link

@ben-childs-docusign ben-childs-docusign commented Nov 17, 2021

Address issue #134

Adds docker image and build script for the centos7 binaries.

Adds the centos7 binary to the nuget package for .net.

Tested consuming the package in a .net project
ran dotnet publish -r centos.7-x64 and verified that the new binary was copied.
ran dotnet publish -r linux-x64 and verified that the old binary was copied.

@ghost
Copy link

ghost commented Nov 17, 2021

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ ben-childs-docusign sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -0,0 +1,6 @@
FROM centos/devtoolset-7-toolchain-centos7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a way to build easily locally on any machine w/ docker installed.
This should also work on azure-pipelines build agents but I did not hook that up here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ben,

Thank you for the PR. Did you test how will consumer of the package in .net know which DLL to load or where to load it from?

Thanks!
-Sergei

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also could you please sign the required CLA above?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sergei
I'm waiting to receive approval to sign the CLA hopefully I can to that soon.
The dll from the centos.7 folder gets published when this command is run:
dotnet publish -r centos.7-x64
If you publish for linux-x64 you get the generic version.

@SergeiAlonichau SergeiAlonichau self-assigned this Nov 23, 2021
@SergeiAlonichau SergeiAlonichau self-requested a review November 23, 2021 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants