Repository navigation
knowledge(data-modeling): distinguish Modify from primary-key Rename - #274
Open
Jesper Schulz-Wedde (JesperSchulz) wants to merge 1 commit into
Open
Jesper Schulz-Wedde (JesperSchulz) wants to merge 1 commit into
Jesper Schulz-Wedde (JesperSchulz) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add one focused data-modeling article explaining why changing a retrieved primary-key field and calling
Modifyis not a record rename, without misreporting legitimate aggregation in a different temporary table.Renamealternative: retain original identity, supply the complete new key, check uniqueness and record freshness, and do not assumeOnModifyruns.Why this belongs in BCQuality
A reviewer can miss a key-changing update or incorrectly carry the same finding forward after the receiver changes to a buffer whose key excludes the accumulated field. That requires interpreting record identity and the full data path, not repeating a compiler/analyzer diagnostic.
data-modelingowns record/key consistency; existing published-schema and performance-aggregation articles address different concerns. No skill or protocol changes are needed.Evidence and applicability
The article cites Microsoft Learn for Rename, Modify, primary keys, temporary tables, TableType, and runtime mapping.
Core guidance applies to all BC versions;
TableType = Temporaryis explicitly limited to runtime 6.0 / BC 17+. The illustrative samples use a temporary record variable and contain no copied application source.Motivated by the public microsoft/BCApps#14006 discussion and static inspection of its subsequent buffer correction. This contribution does not claim a new runtime reproduction or that a green CI result proves execution of a particular regression.
Validation