Skip to content

[Quality Management] Add Quality Inspection Result card#8358

Open
JakovljevicDusan wants to merge 4 commits into
mainfrom
bugs/QM-AddQltyInspectionResultCard
Open

[Quality Management] Add Quality Inspection Result card#8358
JakovljevicDusan wants to merge 4 commits into
mainfrom
bugs/QM-AddQltyInspectionResultCard

Conversation

@JakovljevicDusan
Copy link
Copy Markdown
Contributor

@JakovljevicDusan JakovljevicDusan commented May 27, 2026

What & why

Add card page to make it easier to show all settings.

Linked work

Fixes AB#636815

@JakovljevicDusan JakovljevicDusan requested a review from a team as a code owner May 27, 2026 15:32
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label May 27, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone May 27, 2026
@JakovljevicDusan JakovljevicDusan enabled auto-merge (squash) May 28, 2026 08:12
else
Rec."Evaluation Sequence" := ExistingQltyInspectionResult."Evaluation Sequence" + 1;

ValidateEvaluationSequenceNotUsedElsewhere();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟡\ Medium\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Redundant uniqueness query inside sequence setter

SetDefaultEvaluationSequence already computes max + 1, which is unique at the moment of reading; the immediate call to ValidateEvaluationSequenceNotUsedElsewhere() issues an extra database query for a condition that cannot normally be true, and produces a confusing error for the user if a race condition happens between the two operations.

Recommendation:

  • Remove the ValidateEvaluationSequenceNotUsedElsewhere() call from SetDefaultEvaluationSequence. Uniqueness is already enforced by OnInsertRecord and OnModifyRecord triggers on both pages.
Suggested change
ValidateEvaluationSequenceNotUsedElsewhere();
internal procedure SetDefaultEvaluationSequence()
var
ExistingQltyInspectionResult: Record "Qlty. Inspection Result";
begin
ExistingQltyInspectionResult.SetCurrentKey("Evaluation Sequence");
ExistingQltyInspectionResult.Ascending(false);
if not ExistingQltyInspectionResult.FindFirst() then
Rec."Evaluation Sequence" := 0
else
Rec."Evaluation Sequence" := ExistingQltyInspectionResult."Evaluation Sequence" + 1;
end;

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

auto-merge was automatically disabled June 1, 2026 07:55

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant