[master] [All-e]Fixed asset report 5607 and 4413 showing different results with Declining Balance

[neeleshsinghal]

Workitem :

Bug 636727: [master] [All-e]Fixed asset report 5607 and 4413 showing different results with Declining Balance

Fixes AB#636727

Issue: Report 4413 (Fixed Asset Projected Value Excel) calculates incorrect depreciation amounts for Declining Balance assets when projections cross a fiscal year boundary, producing different results than the legacy Report 5607.

Cause: In InsertProjectedEntries, EntryAmounts[3] (depreciation in fiscal year) was reset to 0 before accumulating the current period's depreciation, causing the last fiscal period's depreciation to spill into the new fiscal year and shifting the effective book value base back one month.

Solution: Moved AccumulateProjectionEntryAmounts before the fiscal year boundary reset (EntryAmounts[3] := 0) so the outgoing fiscal year's final depreciation is fully accumulated before the counter resets, matching the order used in Report 5607.

[AleksanderGladkov]

@neeleshsinghal please also add description to the PR

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

AccountingPeriod.DeleteAll() affects global test state

AccountingPeriod.DeleteAll() removes every accounting period from the database at the start of the test. Other tests that expect accounting periods to exist and run concurrently (or after, if a Commit() persists this) may fail or produce wrong results.

Recommendation:

• Restrict the deletion to only the periods created by this test, or call DeleteAll() only on a filtered record set. Also ensure cleanup is mirrored in a TearDown or within the same transaction boundary.

Suggested change

	AccountingPeriod.DeleteAll();
	// Filter to only the fiscal year range created for this test:
	AccountingPeriod.SetRange("Starting Date", CalcDate('<-1Y>', FiscalYearStartDate),
	CalcDate('<' + Format(NumberOfMonths) + 'M>', FiscalYearStartDate));
	AccountingPeriod.DeleteAll();

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Commit() in test breaks isolation

Calling Commit() inside a test procedure persists all changes to the database, bypassing the automatic transaction rollback that test isolation relies on. If a subsequent assertion fails, the FA journal entries, fixed asset, and accounting periods created in the test will remain in the database and can pollute other tests.

Recommendation:

• Refactor the test to avoid Commit(). If the report runner requires committed data, use a [TransactionModel(TransactionModel::AutoCommit)] attribute or restructure the setup so committed data is cleaned up in a TearDown procedure.

Suggested change

	Commit();
	// Replace the bare Commit() with explicit cleanup or use TransactionModel:
	[Test]
	[TransactionModel(TransactionModel::AutoCommit)]
	[HandlerFunctions('EXRFixedAssetProjectedHandler')]
	procedure ProjectedValueDeclBalShouldUseCorrectBookValueAcrossFiscalYear()

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

AccountingPeriod.DeleteAll() pollutes test data

AccountingPeriod.DeleteAll() is called inside the test body without being wrapped in a LibrarySetupStorage.Save/Restore or equivalent cleanup. If the test fails mid-way, or if other tests running in the same session rely on existing accounting periods, the global table state is permanently corrupted for that test run.

Recommendation:

• Move accounting-period setup and teardown into the Initialize / cleanup helpers, or use LibraryFiscalYear to ensure periods are restored after the test. At minimum, add AccountingPeriod.DeleteAll() to CleanupFixedAssetData with an if IsInitialized guard.

Suggested change

	FiscalYearStartDate: Date;
	// In CleanupFixedAssetData or a dedicated TearDown:
	AccountingPeriod.DeleteAll();
	LibraryFiscalYear.CreateFiscalYear();

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Missing newline at end of file

The diff shows \ No newline at end of file for FixedAssetExcelReports.Codeunit.al. AL source files should end with a trailing newline for consistent diff output and to avoid spurious whitespace changes in future edits.

Recommendation:

• Add a single newline character after the closing } of the codeunit.

Suggested change

	procedure EXRFixedAssetProjectedHandler(var EXRFixedAssetProjected: TestRequestPage "EXR Fixed Asset Projected")
	}

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.

---

🔄 How to trigger a new status check:

1. 📤 Push a new commit to the PR branch, or
2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.