[Shopify] Test failure in UnitTestUpdateTaxRegistrationIdForVATRegistrationNo for Belgian customers#6400
Open
[Shopify] Test failure in UnitTestUpdateTaxRegistrationIdForVATRegistrationNo for Belgian customers#6400
Conversation
…or Belgian customers
haoranpb
approved these changes
Feb 3, 2026
| @@ -171,6 +171,11 @@ codeunit 134246 "Shpfy Tax Id Mapping Test" | |||
| NewTaxRegistrationId := LibraryERM.GenerateVATRegistrationNo(CompanyInformation."Country/Region Code"); | |||
| // [GIVEN] Customer with empty VAT Registration No. | |||
| CreateCustomerWithVATRegNo(Customer, ''); | |||
Contributor
There was a problem hiding this comment.
are we then losing code coverage here in BE?
Consider moving the code into CreateCustomerWithVATRegNo
darjoo
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The unit test
UnitTestUpdateTaxRegistrationIdForVATRegistrationNoinShpfy Tax Id Mapping Testcodeunit was failing when running on the Belgian (BE) localization.The test was attempting to validate a VAT Registration No. on a Customer record, but Belgian localization requires customers to use the "Enterprise No." field instead of "VAT Registration No." for Belgian customers. This triggered the validation error:
Root Cause
When the Company Information has
Country/Region Code= 'BE', theCustomer.VAT Registration No.field validation rejects VAT Registration numbers because Belgian regulations require the use of the Enterprise No. field instead.Solution
Added a condition in the test to detect when running on Belgian localization and handle it by:
Country/Region Codeto 'DE' (Germany) to bypass the Belgian-specific validationChanges
UnitTestUpdateTaxRegistrationIdForVATRegistrationNotestFixes AB#618120