Skip to content

Removed the ReplicateData=false property #10049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bardur Knudsen (BardurKnudsen) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removed the ReplicateData=false property #10049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cab4ee
Removed the ReplicateData=false property
Aug 7, 2026
fbc08e1
Add to CloudMigration Test
Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Layers/W1/BaseApp/Finance/SpendRequest/SpendRequest.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ using System.Security.AccessControl;
table 6840 "Spend Request"
{
Caption = 'Spend Request';
ReplicateData = false;

@github-actions github-actions Bot Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟠\ High\ Severity\ —\ Privacy}$

This PR removes ReplicateData = false; from "Spend Request" (table 6840), "Spend Request Detail" (table 6841), and "Spend Request To G/L Link" (table 6845), and adds all three to the cloud-migration test's expected-table list — enabling OnPrem-to-cloud replication/migration for these tables for the first time. However, most Normal fields in these tables rely solely on the table-level DataClassification = CustomerContent property (e.g. "No.", Type, "Requested By", Status, "G/L Account No.", Purpose, Currency Code, and the various amount/date fields in Spend Request; "Line No.", Description, "Expected Amount" in Spend Request Detail; "Spend Request No.", Amount, "Document No." in Spend Request To G/L Link) instead of an explicit field-level DataClassification. Per BCQuality privacy guidance, a table-level classification does not satisfy the field-level requirement, and migrated/replicated data should have its destination fields explicitly classified. Now that these tables are newly eligible for cloud migration, the previously low-relevance gap in field-level classification becomes a real privacy/compliance concern for data leaving the OnPrem environment.

Knowledge:

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.31.4

DataClassification = CustomerContent;
DataCaptionFields = "No.", Purpose;
Permissions = tabledata "Spend Request Detail" = rimd,
Expand Down
1 change: 0 additions & 1 deletion src/Layers/W1/BaseApp/Finance/SpendRequest/SpendRequestDetail.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ using Microsoft.Finance.GeneralLedger.Account;
table 6841 "Spend Request Detail"
{
Caption = 'Spend Request Document Detail';
ReplicateData = false;
DataClassification = CustomerContent;

fields
Expand Down
1 change: 0 additions & 1 deletion src/Layers/W1/BaseApp/Finance/SpendRequest/SpendRequestToGLLink.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ using Microsoft.Finance.GeneralLedger.Ledger;
table 6845 "Spend Request To G/L Link"
{
Caption = 'Spend Request To G/L Link';
ReplicateData = false;

@github-actions github-actions Bot Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟡\ Medium\ Severity\ —\ Agent}$

This PR's sole change is removing ReplicateData = false; from all three Spend Request tables (6840, 6841, 6845). This silently reverts a deliberate, reviewed

Recommendation:

  • PR Exclude spend request G/L link from replication #9887 ("Exclude spend request G/L link from replication") added ReplicateData = false to table 6845 specifically because an internal cloud migration guard flagged it as an unreviewed table for cloud migration, and that PR's own description states the two parent tables (6840, 6841) already had ReplicateData = false since their introduction in PR Deliverable 638799: Spend Requests in Base App #8959 to keep replication behavior consistent. Removing the property from all three tables reintroduces the exact condition Exclude spend request G/L link from replication #9887 was created to resolve, and does so for all three tables rather than just the one originally flagged. The commit message ("Removed the ReplicateData=false property") gives no rationale for reversing this decision, and there is no accompanying explanation (e.g., a change in cloud migration guard policy, or a business need to now replicate this CustomerContent finance data) in the diff. If this is intentional, the PR description/commit should explain why the migration guard concern no longer applies and why enabling replication for these Spend Request approval tables (which carry CustomerContent classification) is now desired; otherwise this change should likely be reverted or reconsidered before merge.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.31.4

DataClassification = CustomerContent;
LookupPageId = "Spend Request To G/L Link";
DrillDownPageId = "Spend Request To G/L Link";
Expand Down
3 changes: 3 additions & 0 deletions src/Layers/W1/Tests/NewObjectTests-Internal/CloudMigrationPropertyTest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,9 @@ codeunit 135160 "Cloud Migration Property Test"
ListOfTablesToMigrate.Add(Database::"Source Code Setup");
ListOfTablesToMigrate.Add(Database::"Source Code");
ListOfTablesToMigrate.Add(Database::"Special Equipment");
ListOfTablesToMigrate.Add(Database::"Spend Request");
ListOfTablesToMigrate.Add(Database::"Spend Request Detail");
ListOfTablesToMigrate.Add(Database::"Spend Request To G/L Link");
ListOfTablesToMigrate.Add(Database::"Standard Address");
ListOfTablesToMigrate.Add(Database::"Standard Cost Worksheet Name");
ListOfTablesToMigrate.Add(Database::"Standard Cost Worksheet");
Expand Down
Loading