[Shopify] Don't block Shops page when user lacks extension permissions - #10034
Open
Onat Buyukakkus (onbuyuka) wants to merge 1 commit into
Open
[Shopify] Don't block Shops page when user lacks extension permissions#10034Onat Buyukakkus (onbuyuka) wants to merge 1 commit into
Onat Buyukakkus (onbuyuka) wants to merge 1 commit into
Conversation
Onat Buyukakkus (onbuyuka)
temporarily deployed
to
triage
August 6, 2026 16:43 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Onat Buyukakkus (onbuyuka)
enabled auto-merge
August 6, 2026 19:44
SendBelgianLocalizationNotification called ExtensionManagement.IsInstalledByAppId unconditionally in OnOpenPage. That check requires Read+Write permission on 'NAV App Installed App' and errors otherwise, blocking the whole page from opening. Wrap the check in a TryFunction so a permission (or any) error simply skips the non-actionable install notification. Fixes AB#646122 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 71270cfc-012a-4d2a-9fdc-cf13ec1b176c
Onat Buyukakkus (onbuyuka)
force-pushed
the
bugs/646122-shopify-be-notification-permission
branch
from
August 6, 2026 19:44
3569944 to
42c4244
Compare
Onat Buyukakkus (onbuyuka)
added a commit
that referenced
this pull request
Aug 6, 2026
…(NA notification) SendNorthAmericaLocalizationNotification (run from the Shpfy Shops list OnOpenPage) unconditionally called ExtensionManagement.IsInstalledByAppId, which requires both Read and Write permission on NAV App Installed App and raises PermissionErr otherwise - aborting the whole page for any US user without extension-install permissions. Wrap the install-status check in a [TryFunction] so a permission (or any) error simply skips the notification instead of blocking the page; a user who cannot check installation status also cannot install the app, so the prompt would not be actionable for them anyway. Mirrors the Belgian-localization fix in microsoft/BCApps PR #10034. Shopify Connector compiles clean (0 errors / 0 warnings). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 86eff15e-fcd8-43b1-9984-5aca2b37e9f7
github-actions
Bot
added
AL: Apps (W1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
On Belgian (BE) environments, the Shopify Shops list (Page 30102) failed to open entirely for any user without extension-install permissions.
OnOpenPageunconditionally callsShpfy Shop Mgt.SendBelgianLocalizationNotification, which callsExtensionManagement.IsInstalledByAppId. That check (viaExtension Installation Impl, CU 2500) requires both Read and Write permission on theNAV App Installed Apptable and raisesPermissionErr("You do not have the required permissions to install the selected app…") otherwise — aborting the whole page.This wraps the install-status check in a
[TryFunction]so a permission (or any) error simply skips the notification instead of blocking the page. A user who can't check installation status also can't install the app, so the prompt would not be actionable for them anyway.Regression from the notification added in AB#640073.
Linked work
Fixes AB#646122
What I tested and the outcome
Shopify Connectorlocally via the AL toolchain — package generated successfully;al_getdiagnosticsonShpfyShopMgt.Codeunit.alreturns 0 errors / 0 warnings.OnOpenPagepath.NAV App Installed Apppermissions and confirm the page opens with no error and no notification.Risk & compatibility
Low. The behavior change is limited to the BE localization notification path: when the installation check can't be performed, the notification is silently skipped (previously it errored and closed the page). No schema, API, or permission changes.