Skip to content

Add Remaining Amount field and calculation to General Ledger Entries Review page #29575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bertverbeek4PS wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −0
Open

Add Remaining Amount field and calculation to General Ledger Entries Review page #29575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions Apps/W1/ReviewGLEntries/app/src/pages/GeneralLedgerEntriesReview.PageExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,20 @@ using Microsoft.Finance.GeneralLedger.Ledger;

pageextension 22204 "General Ledger Entries Review" extends "General Ledger Entries"
{
layout
{
addafter(Amount)
{
field(RemainingAmount; RemainingAmount)
{
ApplicationArea = Basic, Suite;
Caption = 'Remaining Amount';
Editable = false;
ToolTip = 'Specifies the remaining amount that can be reviewed.';
}
}
}

actions
{
addfirst("Ent&ry")
Expand All @@ -29,4 +43,13 @@ pageextension 22204 "General Ledger Entries Review" extends "General Ledger Entr
}
}
}

trigger OnAfterGetRecord()
begin
Rec.CalcFields("Reviewed Amount");
Copy link
Contributor

@JesperSchulz JesperSchulz Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code was flagged by agent:
Issue
CalcFields() called inside OnAfterGetRecord trigger on G/L Entry table (10M+ rows). This creates N+1 query pattern where every row displayed triggers a separate FlowField calculation query, causing severe performance degradation during page scrolling and rendering.

Recommendation
Remove explicit CalcFields() from OnAfterGetRecord. If 'Reviewed Amount' is a FlowField, bind it directly to a page field - the platform handles FlowField loading more efficiently. Ensure the FlowField's source table has a proper SIFT index (key with SumIndexFields) to optimize the aggregation. If RemainingAmount calculation is required, consider computing it only OnAfterGetCurrRecord (for the focused record) or using a query-based approach.

Copy link
Contributor Author

@Bertverbeek4PS Bertverbeek4PS Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JesperSchulz
Well if I put the field on the page and people are making it invisible it would not calculate because of the feature:
" Calculate only visible FlowFields"
ANd on the OnAfterGetCurreRecord I only have the focussed record

Copy link
Contributor

@JesperSchulz JesperSchulz Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback from the Finance team:

This feature has given us enormous performance issues, inconsistent calculation of Amount to Review and upgrade timeouts. We will not add more calculation to it. These fields are an extension on top of GL Entry - one of the biggest tables of BC with millions of records. Extremely risky to add more calculations.

Copy link
Contributor Author

@Bertverbeek4PS Bertverbeek4PS Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JesperSchulz I can understand it. Maybe close this PR.
But then we also need to close the BC idea with the comment about the performance.

RemainingAmount := Rec.Amount - Rec."Reviewed Amount";
end;

var
RemainingAmount: Decimal;
}
Loading