GP - Post migration validation feature#29395
Open
jaymckinney-enavate wants to merge 21 commits intomicrosoft:mainfrom
Open
GP - Post migration validation feature#29395jaymckinney-enavate wants to merge 21 commits intomicrosoft:mainfrom
jaymckinney-enavate wants to merge 21 commits intomicrosoft:mainfrom
Conversation
Contributor
|
Issue #579005 is not valid. Please make sure you link an issue that exists, is open and is approved. |
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/pages/CompanyMigrationStatus.Page.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/pages/CompanyMigrationStatus.Page.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/pages/IntelligentCloudStatFactbox.Page.al
Show resolved
Hide resolved
Apps/W1/HybridGP/app/src/codeunits/GPMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridGP/app/src/codeunits/GPMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
…Product Type lookup. Updated Codeunit Id.
Apps/W1/HybridBaseDeployment/app/src/codeunits/HybridCloudManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/codeunits/HybridCloudManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/tables/MigrationValidationBuffer.Table.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/tables/MigrationValidationBuffer.Table.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridGP/app/src/pages/IntelligentCloudExtension.PageExt.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/codeunits/MigrationValidatorWarning.Codeunit.al
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/codeunits/MigrationValidation.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/pages/CompanyMigrationStatus.Page.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/tables/CompanyValidationProgress.Table.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/test/src/DummyMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/codeunits/HybridCloudManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/codeunits/HybridCloudManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/codeunits/HybridCloudManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/codeunits/MigrationValidation.Codeunit.al
Outdated
Show resolved
Hide resolved
| Clear(CloudMigrationWarning); | ||
| CloudMigrationWarning."Entry No." := 0; | ||
| CloudMigrationWarning."Warning Type" := CloudMigrationWarning."Warning Type"::"Migration Validator"; | ||
| CloudMigrationWarning.Message := CopyStr(StrSubstNo(CloudMigrationWarningErr, MigrationValidatorRegistry."Validator Code", GetLastErrorText()), 1, MaxStrLen(CloudMigrationWarning.Message)); |
Contributor
There was a problem hiding this comment.
Should we list these as errors if the codeunit has failed running?
We may need a callstack too.
Contributor
Author
There was a problem hiding this comment.
I don't know. I just wanted to reuse the existing Cloud Migration Warning functionality to show a failed validator at least somewhere.
Apps/W1/HybridBaseDeployment/app/src/codeunits/MigrationValidation.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/codeunits/MigrationValidation.Codeunit.al
Outdated
Show resolved
Hide resolved
| // The issue should be reported. | ||
| end; | ||
|
|
||
| procedure ShowWarning(var CloudMigrationWarning: Record "Cloud Migration Warning"): Text |
Contributor
There was a problem hiding this comment.
Nit - The method is not showing the warning it is returning text, the name should be udpated
Contributor
Author
There was a problem hiding this comment.
That is part of the interface, I'm conforming to it. Is there a better way to implement it?
Apps/W1/HybridBaseDeployment/app/src/codeunits/MigrationValidatorWarning.Codeunit.al
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/pages/MigrationValidationErrors.Page.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/tables/MigrationValidationError.Table.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/tables/MigrationValidationError.Table.al
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/tables/MigrationValidationTest.Table.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/tables/ValidationSuiteLine.Table.al
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/tables/ValidationSuiteLine.Table.al
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/tables/MigrationValidationTest.Table.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/test/src/MockMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/pages/IntelligentCloudStatFactbox.Page.al
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #579005