Added dimension setup & posted entries for fixed assets by tuan-nguyen-fenwick · Pull Request #29390 · microsoft/ALAppExtensions

tuan-nguyen-fenwick · 2025-11-07T04:32:37Z

Summary

Added dimension setup and posted entries for Fixed Assets in Demo Data Tool.

Work Item(s)

Excel report outputs showing meaningful data: - [Fixed Asset Projected Value (Excel).xlsx](https://dev.azure.com/fenwick/bf100862-1f7e-4467-bf86-526d4c7ac7eb/_apis/git/repositories/bc6a2808-2da7-4039-8a77-6283538e4d5d/pullRequests/38641/attachments/Fixed%20Asset%20Projected%20Value%20%28Excel%29.xlsx) - [Fixed Asset Details (Excel).xlsx](https://dev.azure.com/fenwick/bf100862-1f7e-4467-bf86-526d4c7ac7eb/_apis/git/repositories/bc6a2808-2da7-4039-8a77-6283538e4d5d/pullRequests/38641/attachments/Fixed%20Asset%20Details%20%28Excel%29.xlsx) - [Fixed Asset Analysis (Excel).xlsx](https://dev.azure.com/fenwick/bf100862-1f7e-4467-bf86-526d4c7ac7eb/_apis/git/repositories/bc6a2808-2da7-4039-8a77-6283538e4d5d/pullRequests/38641/attachments/Fixed%20Asset%20Analysis%20%28Excel%29.xlsx) FA Ledger Entries: ![image.png](https://dev.azure.com/fenwick/bf100862-1f7e-4467-bf86-526d4c7ac7eb/_apis/git/repositories/bc6a2808-2da7-4039-8a77-6283538e4d5d/pullRequests/38641/attachments/image.png) Published to: http://bcdev2.fenwicksoftware.com.au:10320/BC/?company=Demo21-FA Related work items: microsoft#28277

...ContosoCoffeeDemoDataset/app/DemoData/FixedAsset/3.Transactions/CreateFAJnlLines.Codeunit.al

github-actions · 2025-12-17T14:55:12Z

Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed.

JesperSchulz · 2025-12-19T10:48:13Z

Another PR where the local DBs don't build any longer. This time with the following:

[2025-12-19 10:52:02] Invoke-jobNAVCodeunit: Document No. ASSET-ACQ is out of balance by 321.500. Please check that Posting Date, Document Type, Document No. and
--------------------- Amount are correct for each line.  CorrelationId:  f0751f7f-4d76-488e-8cca-e99f776d2632. Status: 400 (Document No.
--------------------- ASSET-ACQ is out of balance by 321.500. Please check that Posting Date, Document Type, Document No. and Amount are
--------------------- correct for each line.) ErrorCode: Application_DialogException  Content:
--------------------- {"error":{"code":"Application_DialogException","message":"Document No. ASSET-ACQ is out of balance by 321.500. Please
--------------------- check that Posting Date, Document Type, Document No. and Amount are correct for each line.  CorrelationId: 
--------------------- f0751f7f-4d76-488e-8cca-e99f776d2632."}}  Headers: Server: Microsoft-HTTPAPI/2.0 request-id:
--------------------- f0751f7f-4d76-488e-8cca-e99f776d2632 WWW-Authenticate: Negotiate oRswGaADCgEAoxIEEAEAAACyeJ/gbKiokAAAAAA= Date: Fri, 19
--------------------- Dec 2025 09:51:46 GMT Content-Type: application/json Content-Length: 266

We need to understand what's happening. But that'll be a job for 2026 😉

tuan-nguyen-fenwick · 2026-01-02T05:42:59Z

Another PR where the local DBs don't build any longer. This time with the following:

[2025-12-19 10:52:02] Invoke-jobNAVCodeunit: Document No. ASSET-ACQ is out of balance by 321.500. Please check that Posting Date, Document Type, Document No. and
--------------------- Amount are correct for each line.  CorrelationId:  f0751f7f-4d76-488e-8cca-e99f776d2632. Status: 400 (Document No.
--------------------- ASSET-ACQ is out of balance by 321.500. Please check that Posting Date, Document Type, Document No. and Amount are
--------------------- correct for each line.) ErrorCode: Application_DialogException  Content:
--------------------- {"error":{"code":"Application_DialogException","message":"Document No. ASSET-ACQ is out of balance by 321.500. Please
--------------------- check that Posting Date, Document Type, Document No. and Amount are correct for each line.  CorrelationId: 
--------------------- f0751f7f-4d76-488e-8cca-e99f776d2632."}}  Headers: Server: Microsoft-HTTPAPI/2.0 request-id:
--------------------- f0751f7f-4d76-488e-8cca-e99f776d2632 WWW-Authenticate: Negotiate oRswGaADCgEAoxIEEAEAAACyeJ/gbKiokAAAAAA= Date: Fri, 19
--------------------- Dec 2025 09:51:46 GMT Content-Type: application/json Content-Length: 266

We need to understand what's happening. But that'll be a job for 2026 😉

Hi @JesperSchulz, Happy New Year!

Can you share which region(s) throwed this error please?

JesperSchulz · 2026-01-06T15:15:07Z

Another PR where the local DBs don't build any longer. This time with the following:

[2025-12-19 10:52:02] Invoke-jobNAVCodeunit: Document No. ASSET-ACQ is out of balance by 321.500. Please check that Posting Date, Document Type, Document No. and
--------------------- Amount are correct for each line.  CorrelationId:  f0751f7f-4d76-488e-8cca-e99f776d2632. Status: 400 (Document No.
--------------------- ASSET-ACQ is out of balance by 321.500. Please check that Posting Date, Document Type, Document No. and Amount are
--------------------- correct for each line.) ErrorCode: Application_DialogException  Content:
--------------------- {"error":{"code":"Application_DialogException","message":"Document No. ASSET-ACQ is out of balance by 321.500. Please
--------------------- check that Posting Date, Document Type, Document No. and Amount are correct for each line.  CorrelationId: 
--------------------- f0751f7f-4d76-488e-8cca-e99f776d2632."}}  Headers: Server: Microsoft-HTTPAPI/2.0 request-id:
--------------------- f0751f7f-4d76-488e-8cca-e99f776d2632 WWW-Authenticate: Negotiate oRswGaADCgEAoxIEEAEAAACyeJ/gbKiokAAAAAA= Date: Fri, 19
--------------------- Dec 2025 09:51:46 GMT Content-Type: application/json Content-Length: 266

We need to understand what's happening. But that'll be a job for 2026 😉

Hi @JesperSchulz, Happy New Year!

Can you share which region(s) throwed this error please?

BuildDatabase_CZ, BuildDatabase_DK and BuildDatabase_NL.

And happy new year 🥳

…dates

tuan-nguyen-fenwick · 2026-01-08T11:52:30Z

@JesperSchulz

I have resolved build errors in CZ, DK and NL environments. Turns out there is a unique G/L account for the cash account in CZ, DK and NL which caused FA journal lines to be out of balance. I had to retrieve the corresponding account in these localised apps.

I also made adjustments to resolve ID conflicts with new objects after merging latest changes from main.

The screenshot below is from BC container platform: CZ 28.0.44120.0

JesperSchulz · 2026-01-08T14:24:18Z

Let me try again!

JesperSchulz · 2026-01-08T15:46:29Z

NL build failed:
CreateFADepreciationBookNL.Codeunit.al(37,29): error AL0185: Codeunit 'Create NL GL Accounts' is missing

tuan-nguyen-fenwick · 2026-01-08T23:10:32Z

NL build failed: CreateFADepreciationBookNL.Codeunit.al(37,29): error AL0185: Codeunit 'Create NL GL Accounts' is missing

@JesperSchulz Thanks, it should be fixed now. I corrected the namespace usage.

tuan-nguyen-fenwick · 2026-01-13T22:36:54Z

@JesperSchulz Please let me know if there’s anything else needed to wrap up this PR. Thanks!

JesperSchulz · 2026-01-14T16:15:28Z

@JesperSchulz Please let me know if there’s anything else needed to wrap up this PR. Thanks!

I'll try running it again with the latest chages.

JesperSchulz · 2026-01-15T09:21:25Z

DK now fails with the following:

�[31;1mInvoke-jobNAVCodeunit: �[31;1mFeltet Bal. Account No. i tabellen Gen. Journal Line indeholder en værdi (18000), som ikke blev fundet i den relaterede�[0m
�[31;1m�[31;1mtabel (G/L Account).  CorrelationId:  5107be2e-f1b5-40bc-92bf-3d4bb0683021. Status: 400 (Feltet Bal. Account No. i�[0m
�[31;1m�[31;1mtabellen Gen. Journal Line indeholder en vÃ¦rdi (18000), som ikke blev fundet i den relaterede tabel (G/L Account).)�[0m
�[31;1m�[31;1mErrorCode: Internal_InvalidTableRelation  Content: {"error":{"code":"Internal_InvalidTableRelation","message":"Feltet�[0m
�[31;1m�[31;1mBal. Account No. i tabellen Gen. Journal Line indeholder en v\u00e6rdi (18000), som ikke blev fundet i den relaterede�[0m
�[31;1m�[31;1mtabel (G/L Account).  CorrelationId:  5107be2e-f1b5-40bc-92bf-3d4bb0683021."}}  Headers: Server: Microsoft-HTTPAPI/2.0�[0m
�[31;1m�[31;1mrequest-id: 5107be2e-f1b5-40bc-92bf-3d4bb0683021 WWW-Authenticate: Negotiate oRswGaADCgEAoxIEEAEAAADqhxSiOHk3ZQAAAAA=�[0m
�[31;1m�[31;1mDate: Wed, 14 Jan 2026 18:51:58 GMT Content-Type: application/json Content-Length: 263�[0m

attilatoury · 2026-01-19T10:23:48Z

Hello @tuan-nguyen-fenwick

Do you have enough information in the previous message to fix the build error?
Let me know if I can help.

…dates

tuan-nguyen-fenwick · 2026-01-22T04:06:23Z

@JesperSchulz @attilatoury I've resolved the FA journal posting error in DK.

BC docker version: DK Business Central 28.0 (Platform 28.0.44791.0 + Application 28.0.44914.0)

JesperSchulz · 2026-01-28T10:13:59Z

Giving this another go!

attilatoury · 2026-01-29T08:08:46Z

@tuan-nguyen-fenwick The build succeeded but I am adding a few comments from our internal code review

attilatoury · 2026-01-29T08:10:52Z

.../ContosoCoffeeDemoDataset/app/DemoData/FixedAsset/1.Setup Data/CreateFAGLAccount.Codeunit.al

+    var
+        CreateGLAccount: Codeunit "Create G/L Account";
+    begin
+        OnBeforeGetCashAccountForFixedAssetAcquisition(GLAccountNo);


Those individual events will soon make the codebase difficult to maintain, to see how we localize GL accounts, see the coding patterns in this file (under the section GL Account):
https://github.com/microsoft/ALAppExtensions/blob/main/Apps/W1/ContosoCoffeeDemoDataset/app/Coding-Patterns.md

Thank you, I've restructured and changed to using more generic event OnBeforeInsertEvent for CZ, NL and DK instead of relying on a custom event.

attilatoury · 2026-01-29T08:11:47Z

...ContosoCoffeeDemoDataset/app/DemoData/FixedAsset/3.Transactions/CreateFAJnlLines.Codeunit.al

+        Codeunit.Run(Codeunit::"Post FA Jnl. Lines");
+    end;
+
+    procedure InsertFAGenJournalLine(JournalTemplateName: Code[10]; JournalBatchName: Code[10]; LineNo: Integer; AccountNo: Code[20]; PostingDate: Date; FAPostingType: Enum "Gen. Journal Line FA Posting Type"; DocumentNo: Code[20]; Description: Text[100]; BalAccountType: Enum "Gen. Journal Account Type"; BalAccountNo: Code[20]; Amount: Decimal)


This type of function should be in the helper codeunit

I've moved it to Contoso Fixed Assets helper codeunit

attilatoury · 2026-01-29T08:14:19Z

...ContosoCoffeeDemoDataset/app/DemoData/FixedAsset/3.Transactions/CreateFAJnlLines.Codeunit.al

+        InsertFAGenJournalLine(FAJournalTemplateName, FAJournalBatchName, 60000, CreateFixedAsset.FA000070(), ContosoUtilities.AdjustDate(19010101D), Enum::"Gen. Journal Line FA Posting Type"::"Acquisition Cost", AssetAcquisitionLbl, AcquisitionLbl, Enum::"Gen. Journal Account Type"::"G/L Account", BalanceAccountNo, 1500);
+        InsertFAGenJournalLine(FAJournalTemplateName, FAJournalBatchName, 70000, CreateFixedAsset.FA000080(), ContosoUtilities.AdjustDate(19010101D), Enum::"Gen. Journal Line FA Posting Type"::"Acquisition Cost", AssetAcquisitionLbl, AcquisitionLbl, Enum::"Gen. Journal Account Type"::"G/L Account", BalanceAccountNo, 11000);
+        InsertFAGenJournalLine(FAJournalTemplateName, FAJournalBatchName, 80000, CreateFixedAsset.FA000090(), ContosoUtilities.AdjustDate(19010101D), Enum::"Gen. Journal Line FA Posting Type"::"Acquisition Cost", AssetAcquisitionLbl, AcquisitionLbl, Enum::"Gen. Journal Account Type"::"G/L Account", BalanceAccountNo, 4000);
+        Codeunit.Run(Codeunit::"Post FA Jnl. Lines");


The posting of documents is usually done in a codeunit under the folder 4.Historical

See https://github.com/microsoft/ALAppExtensions/blob/main/Apps/W1/ContosoCoffeeDemoDataset/app/README.md#2-demo-data-layers

@attilatoury I have moved these under Historical folder.

…dates

…etAcquisition event

…m CZ Demo Data

…unt in CZ

…ount in NL

…ount in DK

JesperSchulz · 2026-01-30T09:13:53Z

All changes merged to internal PR. Running CI...

attilatoury · 2026-01-30T09:20:11Z

...feeDemoDatasetDK/app/DemoData/FixedAsset/1. SetupData/CreateFADepreciationBookDK.Codeunit.al

    end;
+
+    [EventSubscriber(ObjectType::Table, Database::"Gen. Journal Line", OnBeforeInsertEvent, '', false, false)]
+    local procedure OnBeforeInsertGenJournalLineDK(var Rec: Record "Gen. Journal Line")


This subscribes to an event from a BaseApp table and will be executed too many times without being used.
Also, we really want to limit the use of events in these demo data app in general.

If the goal is to use the value from the DK GL account instead of the one from W1, this is what the localization of GL Account is already guaranteeing us: https://github.com/microsoft/ALAppExtensions/blob/main/Apps/DK/ContosoCoffeeDemoDatasetDK/app/DemoData/Finance/1.Setup%20Data/CreateGLAccDK.Codeunit.al

That means that all the inserts done in W1 using W1's GL accounts will actually be using DK's GL accounts (if they have been overwritten in the codeunit linked above).

For specific scenarios where the W1 GL account cannot be localized (e.g. the account only exists in the localization), then one option is to find the data that was inserted in W1, and either delete it and insert it with the localization's values, or modify it.

Hopefully the Contoso Coffee Demo Dataset apps (W1 and all the localizations) provide extensive examples on how to do it.

Note that this also applies to other localized files where this pattern is used.

@attilatoury Thanks for the suggestions.

Just wanted to clarify the above G/L account creation pattern and my PR scenario. This "Create G/L " codeunit is designed to create localized G/L accounts which I totally understand.

In my case, I want to call the localized account that's already been created for the specific country and use it on the FA journal lines. I'm not creating any new account for DK.

For example, W1 cash account = 1234, whereas DK cash account = 6789, my code here calls the DK cash account (6789) and populate on the FA journal lines when generating Fixed Assets data only. The codeunit itself is manual binding so it isn't triggered outside the scope of creating Fixed Assets demo data module.

@tuan-nguyen-fenwick If the account has already been localized, then calling the W1 account will return the DK account (when called from the DK localized app). So, intercepting the data before it is inserted to overwrite the account number should not be needed.

@attilatoury

You're right, calling the W1 cash account CreateGLAccount.Cash() works for all countries except for DK, NL and CZ. It returns a blank value because these countries have different name and account number for the Cash account. And when the balancing account is blank on the Gen. Jnl. Line, it causes out of balance during posting.

And for that reason, I had to call the specific localized account in DK, NL and CZ.

Let me know your thoughts to get this PR moving.

@tuan-nguyen-fenwick In that case, the pattern we use for demo data is "For specific scenarios where the W1 GL account cannot be localized (e.g. the account only exists in the localization), then one option is to find the data that was inserted in W1, and either delete it and insert it with the localization's values, or modify it."

@attilatoury
For example in CZ, it is already been done here in the account localization codeunit where it clears W1 Cash account number (that's same as intercepting and deleting it from CZ environment) and then replaces it the localized account.

https://github.com/microsoft/ALAppExtensions/blob/main/Apps/CZ/ContosoCoffeeDemoDatasetCZ/app/DemoData/Finance/1.%20Setup%20Data/CreateGLAccountCZ.Codeunit.al

@tuan-nguyen-fenwick Right so can you use the same pattern for the other countries that you are modifying?

@attilatoury Since we're approaching the v28 branching date, I don’t think it’s the right time to change how the localized Cash account is created for these countries in this PR. Adjusting this behaviour will require more planning as it may impact other areas of the local Demo Data apps.

There may also be valid functional reasons behind why Cash account is set up differently in these countries, so this needs a broader review if we proceed.

Tuan Nguyen added 5 commits November 5, 2025 16:57

Added dimension setup to fixed assets

2879ddb

Added InsertFixedAsset function that takes FA Posting Group parameter

e4c3ea2

Added FA posting group to fixed asset dataset

122e0f8

Added codeunits to generate FA journal lines & posted entries

b183a44

tuan-nguyen-fenwick requested a review from a team as a code owner November 7, 2025 04:32

tuan-nguyen-fenwick requested a review from haoranpb November 7, 2025 04:32

JesperSchulz added the Finance GitHub request for Finance area label Nov 10, 2025

AndersLarsenMicrosoft self-assigned this Nov 24, 2025

PredragMaricic previously approved these changes Dec 10, 2025

View reviewed changes

...ContosoCoffeeDemoDataset/app/DemoData/FixedAsset/3.Transactions/CreateFAJnlLines.Codeunit.al Outdated Show resolved Hide resolved

Sorted variables and usings

1b8a435

tuan-nguyen-fenwick dismissed PredragMaricic’s stale review via 1b8a435 December 12, 2025 03:29

github-actions bot added the linked Issue is linked to a Azure Boards work item label Dec 12, 2025

PredragMaricic previously approved these changes Dec 14, 2025

View reviewed changes

PredragMaricic requested a review from attilatoury December 14, 2025 10:44

JesperSchulz added the processing-PR The PR is currently being reviewed label Dec 17, 2025

Tuan Nguyen added 8 commits January 8, 2026 22:18

Merge remote-tracking branch 'origin/main' into uptake/fixed-asset-up…

36102d0

…dates

Updated Fixed Asset object IDs

7cf988d

Added GetCashAccountNo function

1d4ce41

Updated FA journal lines creation

a66dec4

Implemented Cash account for fixed asset acquisitions in CZ

b03351a

Added CreateFAJournalSetups function

2421faf

Implemented Cash account for fixed asset acquisitions in DK

3c9f7c9

Implemented Cash account for fixed asset acquisitions in NL

8f5845d

tuan-nguyen-fenwick dismissed PredragMaricic’s stale review via 8f5845d January 8, 2026 11:48

Corrected namespace reference for codeunit "Create NL GL Accounts"

6620676

AndersLarsenMicrosoft previously approved these changes Jan 15, 2026

View reviewed changes

Tuan Nguyen added 2 commits January 22, 2026 13:48

Merge remote-tracking branch 'origin/main' into uptake/fixed-asset-up…

9e69bb1

…dates

Updated G/L account used to acquire fixed assets in DK

e7b5230

tuan-nguyen-fenwick dismissed AndersLarsenMicrosoft’s stale review via e7b5230 January 22, 2026 04:02

attilatoury requested changes Jan 29, 2026

View reviewed changes

Tuan Nguyen added 9 commits January 30, 2026 12:02

Moved FA journal lines coduenit to Historical folder

30f4605

Moved InsertFAGenJournalLine function to Contoso FA codeunit

1b2b9f9

Merge remote-tracking branch 'origin/main' into uptake/fixed-asset-up…

12b4c58

…dates

Replaced GetCashAccountNo by Cash account directly for W1

83304f1

Removed GetCashAccountNo function & OnBeforeGetCashAccountForFixedAss…

68eacee

…etAcquisition event

Removed OnBeforeGetCashAccountForFixedAssetAcquisition subscriber fro…

ef62bbc

…m CZ Demo Data

Added OnBeforeInsertGenJournalLineCZ subscriber to populate Cash acco…

59f2c70

…unt in CZ

Replaced OnBeforeInsertGenJournalLine subscriber to populate Cash acc…

88c2279

…ount in NL

Replaced OnBeforeInsertGenJournalLine subscriber to populate Cash acc…

4f9766c

…ount in DK

tuan-nguyen-fenwick requested a review from attilatoury January 30, 2026 07:13

attilatoury requested changes Jan 30, 2026

View reviewed changes

Conversation

tuan-nguyen-fenwick commented Nov 7, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Work Item(s)

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

JesperSchulz commented Dec 19, 2025

Uh oh!

tuan-nguyen-fenwick commented Jan 2, 2026

Uh oh!

JesperSchulz commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tuan-nguyen-fenwick commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JesperSchulz commented Jan 8, 2026

Uh oh!

JesperSchulz commented Jan 8, 2026

Uh oh!

tuan-nguyen-fenwick commented Jan 8, 2026

Uh oh!

tuan-nguyen-fenwick commented Jan 13, 2026

Uh oh!

JesperSchulz commented Jan 14, 2026

Uh oh!

JesperSchulz commented Jan 15, 2026

Uh oh!

attilatoury commented Jan 19, 2026

Uh oh!

tuan-nguyen-fenwick commented Jan 22, 2026

Uh oh!

JesperSchulz commented Jan 28, 2026

Uh oh!

attilatoury commented Jan 29, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JesperSchulz commented Jan 30, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tuan-nguyen-fenwick commented Nov 7, 2025 •

edited by github-actions bot

Loading

JesperSchulz commented Jan 6, 2026 •

edited

Loading

tuan-nguyen-fenwick commented Jan 8, 2026 •

edited

Loading