Set Additional Reporting Currency demo data for financial reporting by tuan-nguyen-fenwick · Pull Request #28760 · microsoft/ALAppExtensions

tuan-nguyen-fenwick · 2025-06-11T05:11:23Z

Summary

Applies to the W1 Contoso Coffee Demo Data app.
Set Additional Reporting Currency on General Ledger Setup.
Set residual FX gains and losses G/L accounts for EUR and USD currencies.

Work Item(s)

Fixes #28759
Fixes: AB#575835

…ata creation Related work items: microsoft#27141

github-actions · 2025-06-12T12:40:01Z

This issue has been approved for contribution ✅ Thanks for contributing.

JesperSchulz · 2025-06-23T12:47:17Z

@tuan-nguyen-fenwick, please address the CI build issues. Once build passes, we can move on to the next step!

tuan-nguyen-fenwick · 2025-06-26T06:58:52Z

@tuan-nguyen-fenwick, please address the CI build issues. Once build passes, we can move on to the next step!

@JesperSchulz Thanks, I have addressed the build issues.

github-actions · 2025-07-02T10:11:41Z

Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed.

…on logic

JesperSchulz · 2025-07-08T11:20:12Z

Merged recent changes. Will ask for new review.

tuan-nguyen-fenwick · 2025-08-18T07:14:21Z

Hi @elbardel @JesperSchulz, could you review this PR please?

tuan-nguyen-fenwick · 2025-08-22T10:18:45Z

@WaelAbuSeada I have addressed the error causing in MX. The G/L account numbers seem to be conflicting. Please see the latest commit.

WaelAbuSeada · 2025-09-03T15:36:33Z

...oCoffeeDemoDataset/app/DemoData/Finance/2.Master data/CreateAddReportingCurrency.Codeunit.al

+        GLAccountCategory: Record "G/L Account Category";
+        SubCategory: Text[80];
+    begin
+        ContosoGLAccount.AddAccountForLocalization(ResidualFXGainsName(), '9335');


GL account introduced in W1 need to be localized in all countries

tuan-nguyen-fenwick · 2026-01-13T22:29:18Z

@elbardel @WaelAbuSeada I've resolved build errors and merge conflicts. PR is now ready for final review.

tuan-nguyen-fenwick · 2026-01-14T00:38:07Z

@attilatoury FYI, I still have this open PR waiting to merge into v28. I've resolved build errors and latest merge conflicts. Let me know if anything else needed to complete this PR.

I don't have permissions to add reviewers to PR so I can only tag you in comment.

JesperSchulz · 2026-01-19T12:38:55Z

Not sure what happened to this PR... Let me try to port this right away.

WaelAbuSeada · 2026-01-19T13:37:07Z

I have created an internal PR for this

WaelAbuSeada · 2026-01-21T19:59:07Z

This is failing in AT, BE, DE, NL CH, CZ,ES,FI,GB,US and DE. Please fix it and ping me to uptake it again @tuan-nguyen-fenwick

…th specific FX account setup

tuan-nguyen-fenwick · 2026-01-28T00:49:11Z

This is failing in AT, BE, DE, NL CH, CZ,ES,FI,GB,US and DE. Please fix it and ping me to uptake it again @tuan-nguyen-fenwick

@WaelAbuSeada I have push fixes to this PR and confirmed in all countries that failed build validations. Can you please run it again?

Platform version: 28.0.45138.0

AT ✅
BE ✅
DE ✅
CH ✅
CZ ✅
ES ✅
FI ✅
GB ✅

Platform version: 28.0.44120.0

NL ✅

Platform version: 28.0.44935.0

US ✅

tuan-nguyen-fenwick · 2026-01-30T07:24:20Z

@attilatoury Can you help me rerun pipelines to test the fixes please?

attilatoury · 2026-02-02T12:12:36Z

@tuan-nguyen-fenwick I've updated the internal PR and the validation pipelines are being run again.

@WaelAbuSeada FYI (I only updated the PR, not reviewed the changes)

attilatoury · 2026-02-02T14:14:20Z

...oCoffeeDemoDataset/app/DemoData/Finance/2.Master data/CreateAddReportingCurrency.Codeunit.al

+
+using Microsoft.Finance.Currency;
+using Microsoft.Finance.GeneralLedger.Journal;
+using Microsoft.Finance.GeneralLedger.Posting;


@tuan-nguyen-fenwick FYI

App\Apps\W1\ContosoCoffeeDemoDataset\TempSource\app\DemoData\Finance\2.Master data\CreateAddReportingCurrency.Codeunit.al(10,1): error AL0792: Unused using directive 'using Microsoft.Finance.GeneralLedger.Posting;'.
App\Apps\W1\ContosoCoffeeDemoDataset\TempSource\app\DemoData\Finance\2.Master data\CreateAddReportingCurrency.Codeunit.al(9,1): error AL0792: Unused using directive 'using Microsoft.Finance.GeneralLedger.Journal;'.

attilatoury · 2026-02-04T11:07:05Z

...ntosoCoffeeDemoDatasetES/app/DemoData/Finance/2.Master Data/CreateESCurrencyExch.Codeunit.al

    end;
+
+    [EventSubscriber(ObjectType::Codeunit, Codeunit::"Create Add. Reporting Currency", OnBeforeGetResidualCurrencyAccounts, '', false, false)]
+    local procedure GetResidualCurrencyAccountsCH(var FXGainsAccount: Code[20]; var FXLossesAccount: Code[20]; var IsHandled: Boolean)


ES instead of CH?

attilatoury · 2026-02-04T11:07:38Z

@tuan-nguyen-fenwick updated the internal PR and started the build

Tuan Nguyen added 4 commits June 11, 2025 14:30

Set Additional Reporting Currency

02e425d

Created residual FX accounts

346f424

Set residual FX accounts to EUR & GBP currencies

edb7458

Merged PR 35656: Set Additional Currency Code during G/L Setup demo d…

d8dc05f

…ata creation Related work items: microsoft#27141

tuan-nguyen-fenwick requested a review from a team as a code owner June 11, 2025 05:11

tuan-nguyen-fenwick requested a review from elbardel June 11, 2025 05:11

JesperSchulz added approved The issue is approved Finance GitHub request for Finance area and removed approved The issue is approved labels Jun 12, 2025

JesperSchulz self-assigned this Jun 23, 2025

Changed hardcoded currency codes to use the currency functions

523359f

github-actions bot added the linked Issue is linked to a Azure Boards work item label Jun 26, 2025

JesperSchulz added the processing-PR The PR is currently being reviewed label Jul 2, 2025

Added "Create Add. Reporting Currency" codeunit and moved data creati…

908b84c

…on logic

AleksanderGladkov added Integration GitHub request for Integration area and removed Finance GitHub request for Finance area labels Aug 7, 2025

Updated account numbers for residual FX gains/losses

bb87255

JesperSchulz removed their assignment Sep 2, 2025

WaelAbuSeada requested changes Sep 3, 2025

View reviewed changes

AndreasHans added a commit that referenced this pull request Sep 24, 2025

Squashed PR #28760 from ALAppExtensions

fd1a166

AndreasHans added a commit that referenced this pull request Sep 24, 2025

Squashed PR #28760 from ALAppExtensions

cec936a

AndreasHans added a commit that referenced this pull request Sep 24, 2025

Squashed PR #28760 from ALAppExtensions

ae35238

Aleyenda self-assigned this Jan 8, 2026

Aleyenda assigned tuan-nguyen-fenwick and unassigned Aleyenda Jan 8, 2026

Tuan Nguyen added 2 commits January 13, 2026 22:08

Merge remote-tracking branch 'origin/main' into uptake/acy-demo-data

645c982

Removed new residual FX accounts & used existing FX accounts instead

8b82005

tuan-nguyen-fenwick requested a review from WaelAbuSeada January 13, 2026 22:27

attilatoury requested review from AndersLarsenMicrosoft and attilatoury and removed request for elbardel January 19, 2026 10:33

attilatoury previously approved these changes Jan 19, 2026

View reviewed changes

Tuan Nguyen added 3 commits January 22, 2026 16:36

Merge remote-tracking branch 'origin/main' into uptake/acy-demo-data

2b6c8b1

Implemented function to retrieve generic and localized currency accounts

11a923f

Implemented localized currency gains/losses accounts for countries wi…

ab2e881

…th specific FX account setup

tuan-nguyen-fenwick dismissed attilatoury’s stale review via ab2e881 January 28, 2026 00:45

tuan-nguyen-fenwick requested a review from attilatoury February 2, 2026 01:31

attilatoury reviewed Feb 2, 2026

View reviewed changes

Tuan Nguyen added 2 commits February 3, 2026 17:45

Removed unused using directives

2976c8b

Merge remote-tracking branch 'origin/main' into uptake/acy-demo-data

50bb833

attilatoury reviewed Feb 4, 2026

View reviewed changes

Renamed GetResidualCurrencyAccountsES function

74eb3df

Conversation

tuan-nguyen-fenwick commented Jun 11, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Work Item(s)

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

JesperSchulz commented Jun 23, 2025

Uh oh!

tuan-nguyen-fenwick commented Jun 26, 2025

Uh oh!

github-actions bot commented Jul 2, 2025

Uh oh!

JesperSchulz commented Jul 8, 2025

Uh oh!

tuan-nguyen-fenwick commented Aug 18, 2025

Uh oh!

tuan-nguyen-fenwick commented Aug 22, 2025

Uh oh!

WaelAbuSeada Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

tuan-nguyen-fenwick commented Jan 13, 2026

Uh oh!

tuan-nguyen-fenwick commented Jan 14, 2026

Uh oh!

JesperSchulz commented Jan 19, 2026

Uh oh!

WaelAbuSeada commented Jan 19, 2026

Uh oh!

WaelAbuSeada commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tuan-nguyen-fenwick commented Jan 28, 2026

Uh oh!

tuan-nguyen-fenwick commented Jan 30, 2026

Uh oh!

attilatoury commented Feb 2, 2026

Uh oh!

attilatoury Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

attilatoury Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

attilatoury commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tuan-nguyen-fenwick commented Jun 11, 2025 •

edited by github-actions bot

Loading

WaelAbuSeada commented Jan 21, 2026 •

edited

Loading

attilatoury commented Feb 4, 2026 •

edited

Loading