webrepl: send Content-Type: text/html for index#1076
Open
allisonkarlitskaya wants to merge 1 commit intomicropython:masterfrom
Open
webrepl: send Content-Type: text/html for index#1076allisonkarlitskaya wants to merge 1 commit intomicropython:masterfrom
allisonkarlitskaya wants to merge 1 commit intomicropython:masterfrom
Conversation
allisonkarlitskaya
force-pushed
the
webrepl-content-type
branch
2 times, most recently
from
40bd13f to
fa45c55
Compare
Author
|
friendly nudge |
Josverl
suggested changes
Mar 26, 2026
Contributor
Josverl
left a comment
Josverl
left a comment
There was a problem hiding this comment.
I support adding the header as IAFAIK it is actually required according the the current HTML specs , but other browsers have implemented content sniffing when it is absent.
micropython/net/webrepl/webrepl.py
Outdated
| cl.send( | ||
| b"""\ | ||
| HTTP/1.0 200 OK\r | ||
| Content-Type: text/html\r |
Contributor
There was a problem hiding this comment.
This seems to be requirement based on Firefox's strict MIME compliance
If we are adding this tt would make sense to also explicitly add the encoding
Content-Type: text/html; charset=utf-8
Possible in a separate commit.
Author
There was a problem hiding this comment.
Changed as requested!
If we don't do this then Firefox incorrectly guesses text/plain and just shows the source. Adding the Content-Type: fixes the issue. Signed-off-by: Allison Karlitskaya <allison.karlitskaya@redhat.com>
allisonkarlitskaya
force-pushed
the
webrepl-content-type
branch
from
fa45c55 to
381c294
Compare
Josverl
approved these changes
Mar 29, 2026
Author
|
Thanks for the review! I'm unable to merge this for myself |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we don't do this then Firefox incorrectly guesses text/plain and just shows the source. Adding the Content-Type: fixes the issue.