Skip to content

pyproject.toml: Add ruff.lint prefixes to format settings. #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
Merged

pyproject.toml: Add ruff.lint prefixes to format settings. #1059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ff5626
cbor2: Silence missing `__eq__` warning.
Josverl Nov 18, 2025
95fd713
pyproject.toml: Reorganize ruff lint settings for newer ruff.
Josverl Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
[tool.ruff]
exclude = [
extend-exclude = [
"python-stdlib",
"unix-ffi",
]
line-length = 99
target-version = "py38" # enable use of walrus operator
Copy link
Contributor Author

@Josverl Josverl Nov 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped to 3.8 to support the walrus operator which is supported and used.

invalid-syntax: Cannot use named assignment expression (`:=`) on Python 3.7 (syntax was added in Python 3.8)
   --> micropython/bluetooth/aioble/aioble/peripheral.py:137:20
    |
135 |                 (16, _ADV_TYPE_UUID128_COMPLETE),
136 |             ):
137 |                 if uuids := [bytes(uuid) for uuid in services if len(bytes(uuid)) == uuid_len]:
    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
138 |                     resp_data = _append(adv_data, resp_data, code, b"".join(uuids))

I think this would need the same change on the micropython/micropython repo as well

Copy link
Member

@dpgeorge dpgeorge Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would need the same change on the micropython/micropython repo as well

Yes, that's fair enough.


[tool.ruff.lint]
select = [
"ASYNC", # flake8-comprehensions
"ASYNC", # flake8-async
"C4", # flake8-comprehensions
"C90", # McCabe cyclomatic complexity
"DTZ", # flake8-datetimez
Expand Down Expand Up @@ -53,42 +57,40 @@ select = [
# "TRY", # tryceratops
# "UP", # pyupgrade
]
ignore = [
extend-ignore = [
"E722",
"E741", # 'l' is currently widely used
"E741", # 'l' is currently widely used
"F401",
"F403",
"F405",
"E501", # line length, recommended to disable
"E501", # line length, recommended to disable
"ISC001",
"ISC003", # micropython does not support implicit concatenation of f-strings
"PIE810", # micropython does not support passing tuples to .startswith or .endswith
"ISC003", # MicroPython does not support implicit concatenation of f-strings
"PIE810", # MicroPython does not support passing tuples to .startswith or .endswith
"PLC0415", # conditional imports are common in MicroPython
"PLC1901",
"PLR1704", # sometimes desirable to redefine an argument to save code size
"PLR1704", # sometimes desirable to redefine an argument to save code size
"PLR1714",
"PLR5501",
"PLW0602",
"PLW0603",
"PLW2901",
"RUF012",
"RUF100",
"RUF012", # mutable default values in class attributes.
"RUF059", # Unpacked variable `foo` is never used
"RUF100", # duplicate noqa directives.
"SIM101",
"W191", # tab-indent, redundant when using formatter
"W191", # tab-indent, redundant when using formatter
]
line-length = 99
target-version = "py37"
mccabe.max-complexity = 61

[tool.ruff.mccabe]
max-complexity = 61

[tool.ruff.pylint]
[tool.ruff.lint.pylint]
allow-magic-value-types = ["bytes", "int", "str"]
max-args = 14
max-branches = 58
max-returns = 13
max-statements = 166

[tool.ruff.per-file-ignores]
[tool.ruff.lint.per-file-ignores]
"micropython/aiorepl/aiorepl.py" = ["PGH001"]

# manifest.py files are evaluated with some global names pre-defined
Expand All @@ -97,5 +99,3 @@ max-statements = 166

# ble multitests are evaluated with some names pre-defined
"micropython/bluetooth/aioble/multitests/*" = ["F821"]

[tool.ruff.format]
2 changes: 1 addition & 1 deletion python-ecosys/cbor2/cbor2/_decoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class CBORDecodeError(Exception):
break_marker = object()


class CBORSimpleValue(object):
class CBORSimpleValue(object): # noqa: PLW1641
"""
Represents a CBOR "simple value".
:param int value: the value (0-255)
Expand Down
Loading