-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix constant names and typos in aioble examples and deepcopy function #1058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c6bd535 to
e8c0a9c
Compare
dpgeorge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, there are some good fixes here.
I approve all commits except the RST formatting one.
python-stdlib/cmd/cmd.py
Outdated
| ---------------------------------------------------------------------------- | ||
| This is a copy of python's Cmd, but leaves out features that aren't relevant | ||
| or can't currently be implemented for MicroPython. | ||
| .. caution:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't think we should be using RST formatting here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.Rst dropped
python-stdlib/heapq/heapq.py
Outdated
| heapify(x) # transforms list into a heap, in-place, in linear time | ||
| item = heapreplace(heap, item) # pops and returns smallest item, and adds | ||
| # new item; the heap size is unchanged | ||
| heap = [] # creates an empty heap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 4 space indent like the other example code reformatted in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, missed that
|
The rst formatting was a side effect of the work I started with @jimmo to see if/how it would be possible to generate documentation pages from the source files. I have reverted the RST formatting to plaintext.
|
Fixes issue micropython#1055. Signed-off-by: Jos Verlinde <Jos_Verlinde@hotmail.com>
Fixes issue micropython#699. Signed-off-by: Jos Verlinde <Jos_Verlinde@hotmail.com>
Fixes issue micropython#952. Signed-off-by: Jos Verlinde <Jos_Verlinde@hotmail.com>
This is a working alternative to PR micropython#919. Signed-off-by: Jos Verlinde <Jos_Verlinde@hotmail.com>
No changes to versions as only comments and docstrings changed Signed-off-by: Jos Verlinde <Jos_Verlinde@hotmail.com>
Signed-off-by: Jos Verlinde <Jos_Verlinde@hotmail.com>
c48443d to
bfd33d5
Compare
This PR combines a few rather minor fixes of typos in documentation and scripts.
Fixes #1055, #699, #952