TICA fixes #58
Merged
TICA fixes #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magpowell
commented
Apr 24, 2025
| p_lay_copy->expand_dims({n_col, n_z_tilt}); | ||
| p_lev_copy->expand_dims({n_col, n_zh_tilt}); | ||
|
|
||
| for (int ilay=0; ilay<n_zh_tilt; ++ilay) { |
Contributor
Author
There was a problem hiding this comment.
this is the change that fixed the bug for cloud botany test scene
MennoVeerman
approved these changes
Apr 30, 2025
MennoVeerman
approved these changes
May 13, 2025
MennoVeerman
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lack on monotonic decrease in p_lev was causing the bug for a cloud botany scene but was not the cause of the increased bias in high SZA aerosols:
I'd recommend using TICA with caution with aerosols.