fix: [BOUNTY] WearOS Support [$1340]#3466
Open
asiokun wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2843
The changes look clean and correct. Here's a summary of what was changed:
Files changed:
play-services-core/src/main/kotlin/com/google/android/gms/wearable/consent/TermsOfServiceActivity.ktRESULT_CANCELED→RESULT_OK. The ToS activity is triggered by thecom.google.android.gms.wearable.TOSintent during WearOS device pairing. The stub was always returningRESULT_CANCELED, which immediately aborted the pairing flow before any device setup could proceed. microG has no proprietary ToS to enforce, so it should return OK.play-services-wearable/core/src/main/java/org/microg/gms/wearable/WearableImpl.javaFour bug fixes:
getConfigurations()— Added null guards afterconfigDatabase.getAllConfigurations()returns null (possible if the database cursor fails). Previously the for-each over a null array would crash with NPE.onConnectReceived()— Fixedconfig.nodeId.equals(nodeId)(NPE whenconfig.nodeIdis null in a fresh/partia