Fido: Disable screen sign-in without local registration#3459
Open
p1gp1g wants to merge 1 commit into
Open
Conversation
Avoid a crash, when the user clicks on screen sign-in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid a crash, when the user clicks on screen sign-in and there isn't any local registration
For that, we prevent the user to select the screen sign-in entry in the transport selection view by excluding SCREEN_LOCK from the implemented transports. When a transport isn't implemented, it is grayed out and disabled.
That way the user see there could be an option to login with SCREEN_LOCK but is currently not available