-
-
Notifications
You must be signed in to change notification settings - Fork 79
feat: Add netlify.toml to enable deploy previews for PRs #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: caesarsage <destinyerhabor6@gmail.com>
|
@Caesarsage have you been able to test it on a fork and your own setup of Netlify? |
Hi @yada, I’ve tested the Netlify setup on my fork. The configuration seems correct, the preview shows but I’m running into a build issue—npm run build times out on some partials on Netlify, even though it builds fine locally. This is likely due to a timeout or environment difference, |
|
Hi @Caesarsage , Call from: At the same time, the head.html is using references to a bunch of partials that aren’t in your repo ( But, looks like we have a performance cliff: Hugo is spending huge time in image rendering partials, and it is not due to The template metrics show: Meanwhile, So the solution is certainly (hope so), to: fix image processing time + raise Hugo timeout. Can you check and validate these points on your setup? 1/ Fix (Netlify): raise Hugo timeout To prevent Hugo from aborting page rendering while it’s crunching images. 2/ Next (if 1/ solve the build issue), and as a great improvement, we may check how to bypass resizing in previews... |
Thanks @yada I will go through this and so some investigation |
… add-netlify-config
|
I investigated the build performance issue and found it was caused by a missing image shortcode, which led to recursive template calls and excessive image processing. I’ve now created a proper image shortcode with responsive and lazy loading support. The cumulative image processing time has dropped significantly, and the build is stable and efficient. All image references now work as intended. |
…eout Signed-off-by: caesarsage <destinyerhabor6@gmail.com>
a7611b8 to
63ce6a9
Compare
Re-testing mine and it works preview(changed Docs to Documentation) : https://deploy-preview-3--microcks.netlify.app/ |
yada
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with thanks
Description
This PR adds a
netlify.tomlconfiguration file to enable deploy previews for pull requests, addressing the issue where previews don't reflect PR branch changes.Related to fixing #334 effort
Action Required by Maintainers
This PR provides the configuration, but a maintainer with Netlify access must:
References:
Additional Notes
@yada @lbroudoux Please review and enable deploy previews in the Netlify dashboard once merged.