Skip to content

Malformed local configuration is silently accepted and can be overwritten - #616

Closed
aniket866 wants to merge 2 commits into
microcks:masterfrom
aniket866:fix/reject-malformed-local-config
Closed

Malformed local configuration is silently accepted and can be overwritten#616
aniket866 wants to merge 2 commits into
microcks:masterfrom
aniket866:fix/reject-malformed-local-config

Conversation

@aniket866

@aniket866 aniket866 commented Oct 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

changes

Malformed local configuration is silently accepted and can be overwritten

Changes:

  • localconfig.go now returns a typed KindEnvironment error when main config YAML parsing fails.
  • localconfig.go does the same for watch configuration.
  • Missing files still return nil, nil.
  • Added regression tests in localconfig_malformed_test.go.
  • Tests verify malformed files remain unchanged.
  • Restored the issue description to its previous content.

Closes #615
Ai disclosure : chatgpt is used to review related files and do changes

@aniket866
fix: reject malformed local configuration
14181ac 
Signed-off-by: aniket866 <iamaniketkumarmaner@gmail.com>
@aniket866
aniket866 requested a review from Caesarsage as a code owner October 31, 2026 22:04
@aniket866 aniket866 changed the title fix: reject malformed local configuration Malformed local configuration is silently accepted and can be overwritten Oct 31, 2026
@aniket866
test: handle login response write errors
c8f59c6 
Signed-off-by: aniket866 <iamaniketkumarmaner@gmail.com>
@Caesarsage

Caesarsage commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Thanks @aniket866! This is already being fixed in #574 for #572, so please coordinate with Sarthak there. If there's no update by Nov 6, feel free to reopen this; otherwise pick another triage/accepted issue.

@Caesarsage Caesarsage closed this Nov 4, 2026

This branch was successfully deployed

1 active deployment
Build — c8f59c66 Deployed Oct 31, 2026 by aniket866 via build-verify-package #857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lbroudoux lbroudoux Awaiting requested review from lbroudoux lbroudoux is a code owner
@yada yada Awaiting requested review from yada yada is a code owner
@Harsh4902 Harsh4902 Awaiting requested review from Harsh4902 Harsh4902 is a code owner
@Caesarsage Caesarsage Awaiting requested review from Caesarsage Caesarsage is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Malformed local configuration is silently accepted and can be overwritten

2 participants

@aniket866 @Caesarsage