CI/CD Pipeline False Positives: import-dir Exits with Code 0 on Failures#474
CI/CD Pipeline False Positives: import-dir Exits with Code 0 on Failures#474aniket866 wants to merge 1 commit into
import-dir Exits with Code 0 on Failures#474Conversation
Signed-off-by: aniket866 <iamaniketkumarmaner@gmail.com>
|
@Vaishnav88sk do checkout this one too |
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 30 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. Microcks is a Cloud Native Computing Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
| fmt.Printf("\nImport completed: %d/%d files imported successfully\n", result.SuccessCount, result.TotalFiles) | ||
| if result.FailedCount > 0 { | ||
| os.Exit(1) | ||
| } |
There was a problem hiding this comment.
This is the right behavior change for CI/CD, but please add a test that covers the partial-failure path and verifies we return a non-zero exit when FailedCount > 0.
Issue
graph TD A[Start import-dir] --> B[Scan Directory] B --> C[Import File 1: Success] B --> D[Import File 2: FAILED] C & D --> E[Display Results Summary] E --> F["Exit Status Code 0 (Success)"] F --> G["CI/CD pipeline reports green/success despite failures"]Steps to Reproduce
microcks import-dir ./specswhere at least one spec has invalid content.✗ Failed: ....echo $?or$LASTEXITCODEin PowerShell). It returns0.fixed: #473
@Harishrs2006 @lbroudoux
Please do review