You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Previously the fenced code blocks in the .md files used language tags inconsistently. This adds languages to all of them (except for ones that just contain plaintext list of actions).
Using jsonc for the json snippets that contain comments allows Github to highlight them properly.
Using jsonc for the json snippets that contain comments allows Github to highlight them properly.
Shouldn't we use jsonc directly for all json blocks, regardless of whether we're already using comments or not?
The advantage of this is that any comments added are displayed correctly without requiring further changes to the fenced code block.
I greped over the remaining ```.
What do you think about harmonizing README.md with ```sh (all of them are sh, even the one with bash) and runtime/syntax/README.md with the syntax_converter.go line?
I greped over the remaining ```. What do you think about harmonizing README.md with ```sh (all of them are sh, even the one with bash) and runtime/syntax/README.md with the syntax_converter.go line?
I think that's a good idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the fenced code blocks in the .md files used language tags inconsistently. This adds languages to all of them (except for ones that just contain plaintext list of actions).
Using
jsoncfor the json snippets that contain comments allows Github to highlight them properly.closes #2704