util: Add tests for rune, whitespace and path helpers - #4154
Open
Qalipso wants to merge 1 commit into
Open
Conversation
internal/util was at 10.7% statement coverage. This covers the pure helpers: rune classification, whitespace handling, rune-indexed slicing, unquoted index scanning, bool parsing, path/cursor parsing, md5 hashing, character decoding with combining marks, and the Lua helper wrappers. Coverage goes from 10.7% to 61.5%. No non-test code is changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/utilis at 10.7% statement coverage, despite being made up largely of small pure helpers that are easy to test and are used throughout the editor.This adds table-driven tests for:
IsWordChar,IsAlphanumeric,IsUpper/LowerLetter,IsAutocomplete, …)GetLeadingWhitespace,GetTrailingWhitespace,IsSpacesOrTabs, …)SliceStart,SliceEnd, and the string variants)IndexAnyUnquoted,ParseBool,Clamp,Abs,Min/Max,IntOptGetPathAndCursorPosition, including the Windows absolute path caseGetCharPosInLinetab handling andHashStringMd5DecodeCharacter,CharacterCount)lua.goCoverage goes from 10.7% to 61.5%. No non-test code is changed;
go vetandgo test -racepass.